-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue banner is not seen for received NFT once the new user has completed onboarding process and is on homepage #2797
Comments
Not quite sure which blue banner we're expecting here, @kathaypacific thoughts? is it an in-app notification of some sort? |
i'm also not clear on what bug is being raised here. you should only see a blue banner (i.e. in-app push notification) if you're receiving a notification for a new token / NFT received. in the video there is no token received, so why would there be a blue banner? |
i'm going to close this because i think the root cause is similar to this issue #2798 where the invitee never received an NFT reward (in the video, there is clearly no transaction item for any NFT received) if any strong objections, feel free to reopen the ticket with more details :) |
Hey @kathaypacific here is the attachment referring to the blue banner and we are sorry for not uploading it, as we were not receiving NFT due to limitation Attachment : bluebanner.jpg CC: @MuckT |
Hi @ValoraQA thanks for the screenshot. i understand that you expected to see this blue banner, however you should only see the blue banner if you received an NFT reward. in the video attached to the description of this ticket, it is not clear that you received a reward. if the invitee address is not one of the 3 i mentioned here #2798 (comment) then you will not receive a reward and therefore should not expect to see the banner. please confirm. |
@kathaypacific if you observe at 00.24 seconds , you will be able to see invited amount as well as NFT received |
Hi @ValoraQA the blue banner is the equivalent of a push notification , and is sent by a backend service. sometimes the home feed update and push notification don't arrive exactly at the same time which is acceptable (a few minutes difference at most). can you confirm that the device used here had push notifications enabled for Valora, and if you received a push notification at a later time? if so, this is acceptable behaviour. |
Hey @kathaypacific let us investigate more on this and get back to you , we will also provide a proper attachment of both the platform behaviors @MuckT can you help us here so we can provide observations more appropriately |
@ValoraQA the behavior you reported is expected if you don't have push notifications enabled, or if the push notification was received but at a slight delay. this is only a valid bug if you had push notifications enabled and you never received a push notification. can you please confirm whether this is the case? |
@kathaypacific & @ellenwoconnor we should leave this open until the staged rollout is completed and the invite rewards can be tested on new accounts. We should make sure to test this on iOS tomorrow during the invite rewards final testing. |
Hey @MuckT we have verified the above issue on latest iOS Test Flight release build and Android Internal Release build V 1.39.1 and observed issue is faced for iOS Platform Observation : Blue banner is not seen once the user has created a new account via invite link
Attachments : ios.mp4, Android.mp4 **Account addresses : ** Devices : iPhone 13mini (15.1.1) , Google Pixel 4a(12.0) Thanks..! |
I had a look into this - i think 0xab3c019195d2905b1d5d2797f3b0ee02159edecb is used for the iOS device and 0x487f91f06f5c6071e6bcd0afda89edc1e7597f35 is for android. we have an event handler that listens for notifications from firebase, and then handles the event by showing the notification. the first thing that we do after receiving an event from firebase is dispatch an event called so working backwards from there, it seems like the iOS device did not seem to receive a notification from firebase (rather than something bad happened and we did not display the notification) :/ i'm not really sure why this would be the case, @ValoraQA can you confirm if push notifications are enabled on the device you used? if the device still has the account 0xab3c019195d2905b1d5d2797f3b0ee02159edecb active (i.e. you did not delete the app since observing the issue) can you please send through the logs so that we can take a deeper look? a quick sleuth on google suggested in some specific scenarios, the firebase messaging event handler does not always fire correctly which is a bit beyond our control, but we should investigate a bit more to see if we fall into these scenarios. |
Hey @kathaypacific we had removed the app where account address : 0xab3c019195d2905b1d5d2797f3b0ee02159edecb was present and tried for new account again Inviter account address : 0x db63 ac3d 06f4 1cfb aedd 526f a3e7 5e25 846e 7101 Observation:
Attachment : bluebanner.mp4 Cc: @MuckT |
Hey @kathaypacific we have tried again to check whether blue banner is seen or not after inviting another user and we are also attaching logs which can you help you out Inviter account address : 0x db63 ac3d 06f4 1cfb aedd 526f a3e7 5e25 846e 7101 Observation:
Suggestion : Can we show a pop up to a user where he is trying to invite more than 3 other users as limit is of 3 NFT's Attachment : bluebanner1.mp4 Cc: @MuckT |
thanks for sending the logs. i can see that a notification was sent to this address from our backend service at 9:59am, so the notification service is working as expected. when the app mounts, we create a listener for firebase messages. i cannot see this listener being initiated at all in the logs attached, but i cannot reproduce it locally on an iOS simulator. when i create a new account, i can see the listener is mounted correctly. to be honest, i don't think this is a big issue. the point of the notification is to inform users that something has happened, and the homefeed updating here serves that purpose. i'd be curious to see whether you receive a push notification when the app is closed, if not then we should investigate that because that has a bigger impact. |
@kathaypacific we have checked for whether we are receiving push notification or not for both the platforms and below are our observation FYI : We have enabled push notifications every time when a new account is created to check.
Attachment : 2] Push notification is not received when user has created the account and app is in background state ,
Attachment : Cc: @MuckT |
Frequency : 100%
Repro on build version: iOS TestFlight release build V:1.38.2
Repro on device : iPhone 12(14.7.1), iPhone 13 mini (15.1.1)
Does not Repro on build version: Android internal release build V:1.38.2
Does not repro on device : Google Pixel 2XL(11.0) , Google Pixel XL(10.0)
Pre-condition:
1] User A must have installed the application
2] User A must have send an invite link to User B
Repro Steps :
1] User B must verify the phone number and enter OTP
2] after entering OTP user B should be redirected to homepage
Bug : Once the user is redirected to homepage then Blue banner stating NFT received is not seen on iOS Platform
Expected Behavior : Blue banner stating NFT received should be seen on iOS Platform as received on Android Platform
Investigation : For Android Platform we are able to see blue banner on receiving the NFT and also invited amount is getting credited in the account
Attachment : bluebanner.mp4
Bug Observed at 0.08 seconds
The text was updated successfully, but these errors were encountered: