-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDN link , web distribution #9
Comments
for UMD
and then |
Here is fiddle https://jsfiddle.net/bababalcksheep/o4qn7jwe/48/ with UMD and this lib does not work correctly for nested groups. |
I added a build for iife for browsers (https://raw.githubusercontent.com/valoricDe/MultiRegExp2/master/dist/multiRegExp2.js). In the jsfiddle I do not see nested regexps. Could you write the regexp here and the expected output? |
https://regex101.com/r/V16o77/1 In ur case , full matach which is first result is ok , |
in any case, consider using UMD over iife , requireJs is still around |
I added UMD regarding the matches. I added a testcase for your issue and it correctly returns a matching group with start 1 and end 13. Could you clone the project and run npm test? |
|
Give me sometime and i will make a jsfiddle with all of my test cases . thankx |
Moving on here #10 and with UMD present , there is no need of iife |
no dist folder at https://www.jsdelivr.com/package/npm/multi-regexp2 |
It will be very helpful if there is a CDN link so that lib can be tested .
https://github.com/valoricDe/MultiRegExp2/blob/master/dist/multiRegExp2.js
file is also wrong for web distribution as ther is no UMD wrapper
Just paste code in any jsfiddle and run to see compatibility
The text was updated successfully, but these errors were encountered: