You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our use of fasthttp, we've encountered this issue as one of our downstream services supports gets with a body. I've been doing some reading and it seems that the spirit of the HTTP spec is that non-posts have no restrictions on having a body, but no logic should be done on the body of a non-POST request so checking its size to produce an error shouldn't be how its done. Rather, the body should just be passed along and not checked by the HTTP implementation.
I think that it makes sense to avoid throwing an error on non-POST requests with a body based on the aforementioned. Would it be possible to change this behavior? It seems to be from here
The text was updated successfully, but these errors were encountered:
In our use of fasthttp, we've encountered this issue as one of our downstream services supports gets with a body. I've been doing some reading and it seems that the spirit of the HTTP spec is that non-posts have no restrictions on having a body, but no logic should be done on the body of a non-POST request so checking its size to produce an error shouldn't be how its done. Rather, the body should just be passed along and not checked by the HTTP implementation.
As seen in the HTTP spec for GET requests, there is no restriction on e.g. a GET request having a body.
On other projects on GitHub, I've seen similar issues come up and I feel this comment states it well: postmanlabs/postman-app-support#131 (comment)
I think that it makes sense to avoid throwing an error on non-POST requests with a body based on the aforementioned. Would it be possible to change this behavior? It seems to be from here
The text was updated successfully, but these errors were encountered: