Align mavenCentralUsername and mavenCentralPassword configuration with other project properties #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urable project properties Retains provider syntax while enabling mavenCentralUsername and mavenCentralPassword to be configured through a broader range of project properties, consistent with other properties in this plugin (e.g. SONATYPE_HOST).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retains provider syntax while enabling
mavenCentralUsernameandmavenCentralPasswordto be configured through a broader range of project properties, consistent with other properties in this plugin (e.g.SONATYPE_HOST).My use case involves providing values decrypted in a Gradle task after the configuration phase, which is not currently feasible with standard Gradle properties. I believe this change would also benefit other scenarios, such as loading values from a unique properties file and other CI-centric configurations.
This PR may overlap with #824, but I believe my approach adds more general utility by allowing values to be set after the configuration phase and brings consistency to the way properties are configured across the plugin.
I attempted to run the tests using
./gradlew check, but many failed in my development environment. However, I was able to confirm that the same tests passed and failed consistently before and after my changes.