Actually save default splitter to config (#174)

variar · May 2, 2021 · 0baf954 · 0baf954
1 parent 65147ca
commit 0baf954
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/src/ui/src/abstractlogview.cpp b/src/ui/src/abstractlogview.cpp
@@ -1641,7 +1641,7 @@ void AbstractLogView::createMenu()
 
     saveDefaultSplitterSizesAction_ = new QAction( tr( "Save splitter position" ), this );
     connect( saveDefaultSplitterSizesAction_, &QAction::triggered,
-             [ this ]( auto ) { this->saveDefaultSplitterSizes(); } );
+             [ this ]( auto ) { emit saveDefaultSplitterSizes(); } );
 
     popupMenu_ = new QMenu( this );
     highlightersMenu_ = popupMenu_->addMenu( "Highlighters" );

diff --git a/src/ui/src/crawlerwidget.cpp b/src/ui/src/crawlerwidget.cpp
@@ -248,7 +248,7 @@ void CrawlerWidget::keyPressEvent( QKeyEvent* keyEvent )
 void CrawlerWidget::changeEvent( QEvent* event )
 {
     if ( event->type() == QEvent::StyleChange ) {
-        dispatchToMainThread( [ this ] {
+        dispatchToMainThread( [this] {
             loadIcons();
             searchInfoLineDefaultPalette = this->palette();
         } );
@@ -531,7 +531,7 @@ void CrawlerWidget::markLinesFromFiltered( const std::vector<LineNumber>& lines
     std::vector<LineNumber> linesInMain;
     linesInMain.reserve( lines.size() );
     std::transform( lines.begin(), lines.end(), std::back_inserter( linesInMain ),
-                    [ this ]( const auto& filteredLine ) {
+                    [this]( const auto& filteredLine ) {
                         if ( filteredLine < logData_->getNbLine() ) {
                             return logFilteredData_->getMatchingLineNumber( filteredLine );
                         }
@@ -1006,9 +1006,9 @@ void CrawlerWidget::setup()
     connect( visibilityBox, QOverload<int>::of( &QComboBox::currentIndexChanged ), this,
              &CrawlerWidget::changeFilteredViewVisibility );
 
-    connect( logMainView, &LogMainView::newSelection, [ this ]( auto ) { logMainView->update(); } );
+    connect( logMainView, &LogMainView::newSelection, [this]( auto ) { logMainView->update(); } );
     connect( filteredView, &FilteredView::newSelection,
-             [ this ]( auto ) { filteredView->update(); } );
+             [this]( auto ) { filteredView->update(); } );
 
     connect( filteredView, &FilteredView::newSelection, this, &CrawlerWidget::jumpToMatchingLine );
 
@@ -1054,7 +1054,12 @@ void CrawlerWidget::setup()
     connect( filteredView, &FilteredView::clearSearchLimits, this,
              &CrawlerWidget::clearSearchLimits );
 
-    auto saveSplitterSizes = [ this, &config ]() { config.setSplitterSizes( this->sizes() ); };
+    auto saveSplitterSizes = [this]() {
+        LOG_INFO << "Saving default splitter size";
+        auto& splitterConfig = Configuration::get();
+        splitterConfig.setSplitterSizes( this->sizes() );
+        splitterConfig.save();
+    };
 
     connect( logMainView, &LogMainView::saveDefaultSplitterSizes, saveSplitterSizes );
     connect( filteredView, &FilteredView::saveDefaultSplitterSizes, saveSplitterSizes );
@@ -1249,7 +1254,7 @@ void CrawlerWidget::changeDataStatus( DataStatus status )
 // Determine the right encoding and set the views.
 void CrawlerWidget::updateEncoding()
 {
-    const QTextCodec* textCodec = [ this ]() {
+    const QTextCodec* textCodec = [this]() {
         QTextCodec* codec = nullptr;
         if ( !encodingMib_ ) {
             codec = logData_->getDetectedEncoding();