Switch to C++ 17

Supported on all target platforms. More warnings, nodiscard, std::byte
and other good things to write cleaner code.

CMakeLists.txt

@@ -64,7 +64,7 @@ set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${out_dir}")
 
 set (CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
 
-set(CMAKE_CXX_STANDARD 14)	
+set(CMAKE_CXX_STANDARD 17)	
 set(CMAKE_CXX_STANDARD_REQUIRED ON)	
 #set(CMAKE_CXX_EXTENSIONS OFF)
 

src/ui/src/crawlerwidget.cpp

@@ -556,11 +556,7 @@ void CrawlerWidget::applyConfiguration()
 
     // Necessary on systems doing subpixel positionning (e.g. Ubuntu 12.04)
     if ( config.forceFontAntialiasing() ) {
-        font.setStyleStrategy( static_cast<QFont::StyleStrategy>( QFont::ForceIntegerMetrics
-                                                                  | QFont::PreferAntialias ) );
-    }
-    else {
-        font.setStyleStrategy( QFont::ForceIntegerMetrics );
+        font.setStyleStrategy( QFont::PreferAntialias );
     }
 
     logMainView->setFont( font );

src/ui/src/infoline.cpp

@@ -63,7 +63,7 @@ void InfoLine::displayGauge( int completion )
     // Create a gradient for the progress bar
     QLinearGradient linearGrad( changeoverX - 1, 0, changeoverX + 1, 0 );
     linearGrad.setColorAt( 0, origPalette_->color( QPalette::Highlight ) );
-    linearGrad.setColorAt( 1, origPalette_->color( QPalette::Background ) );
+    linearGrad.setColorAt( 1, origPalette_->color( QPalette::Window ) );
 
     // Apply the gradient to the current palette (background)
     QPalette newPalette = *origPalette_;

src/ui/src/tabbedcrawlerwidget.cpp

@@ -150,7 +150,7 @@ void TabbedCrawlerWidget::mouseReleaseEvent( QMouseEvent* event )
 {
     LOG_DEBUG << "TabbedCrawlerWidget::mouseReleaseEvent";
 
-    if ( event->button() == Qt::MidButton ) {
+    if ( event->button() == Qt::MiddleButton ) {
         int tab = this->myTabBar_.tabAt( event->pos() );
         if ( -1 != tab ) {
             emit tabCloseRequested( tab );