Try.of() shouldn't soften exceptions by changing exception category for rethrown (fatal) exceptions

[nfekete]

Try.of() currently catches all exceptions and rethrows them if fatal in a wrapper exception. The wrapper for fatal exceptions is javaslang.control.Try.FatalException, which extends java.lang.RuntimeException, this way it changes exception categories and softens Errors (possibly java.lang.VirtualMachineError and subclasses) to RuntimeExceptions.

[nfekete]

See for example google guava introduced ExecutionError as a counterpart of JDK's ExecutionException to wrap Errors to keep the semantics of the exception type categories. Also UncheckedExecutionException for wrapping RuntimeException.

[danieldietrich]

I thought you meant including 'NotImplementedError' into the set of fatal exceptions when you said to create a ticket for Try.Fatal :)

This issue will be solved when we solve #1722.

[nfekete]

No, why would I want to make it fatal? I was arguing for great lengths to make TODO() use a softer exception, not a more severe one :)