From 97f76de289c6af12c616ba39d431036b2ec6e7c2 Mon Sep 17 00:00:00 2001 From: Evgeny Lazin <4lazin@gmail.com> Date: Fri, 19 Jan 2024 05:24:42 -0500 Subject: [PATCH] archival: Delete replaced segments during spillover GC Previously, if the spillover was enable we weren running normal GC during the housekeeping run. Normal housekeeping is responsible for removing segments evicted due to retention (which is not happening if spillover region is not empty). But it also removes replaced segments. So essentially, we have to run both types of GC on every spillover housekeeping run. --- src/v/archival/ntp_archiver_service.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/v/archival/ntp_archiver_service.cc b/src/v/archival/ntp_archiver_service.cc index 7c2a769ff606d..88f2f0997821d 100644 --- a/src/v/archival/ntp_archiver_service.cc +++ b/src/v/archival/ntp_archiver_service.cc @@ -2159,6 +2159,7 @@ ss::future<> ntp_archiver::housekeeping() { } else { co_await apply_archive_retention(); co_await garbage_collect_archive(); + co_await garbage_collect(); } co_await apply_spillover(); }