Skip to content

Commit

Permalink
archival/test: Ensure archiver is stopped
Browse files Browse the repository at this point in the history
If the test affected by this change fails, archiver is destroyed without
stopping. This also destroys the scrubber, which may have requests
active keeping its gate open.

This triggers an assertion from seastar related to gate destroyed while
requests active. Usually this is prominently visible but in this test it
results in the ctest invocation hanging in CI.

This causes the build to hang and timeout. The root cause is the
test_manifest_spillover not adding segments to the archival meta STM,
which can be investigated separately. This change should enable the test
to fail in a visible manner with logs seen in CI instead of hanging.
  • Loading branch information
abhijat committed Nov 28, 2023
1 parent 3327b9e commit ef8a420
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/v/archival/tests/ntp_archiver_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1732,6 +1732,8 @@ static void test_manifest_spillover_impl(
*part,
amv);

auto stop_archiver = ss::defer([&archiver] { archiver.stop().get(); });

// Do not start archiver and run spillover manually.
vlog(
test_log.debug,
Expand Down

0 comments on commit ef8a420

Please sign in to comment.