From 13b4aa48c12bcbe3723ceab1aac5539729d33b28 Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sat, 25 Nov 2023 20:06:14 -0800 Subject: [PATCH 1/7] build/pkgs/nauty: Update to 2.8.8 --- build/pkgs/nauty/package-version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/pkgs/nauty/package-version.txt b/build/pkgs/nauty/package-version.txt index 04e60eaa37a..80803faf1b9 100644 --- a/build/pkgs/nauty/package-version.txt +++ b/build/pkgs/nauty/package-version.txt @@ -1 +1 @@ -2.8.6.p1 +2.8.8 From 0c0e49d8387068bda1511d4084b022f8678ed76e Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sat, 25 Nov 2023 20:09:11 -0800 Subject: [PATCH 2/7] build/pkgs/nauty/patches/nauty-2.8.6-gentreeg-gentourng.patch: Remove --- .../nauty-2.8.6-gentreeg-gentourng.patch | 144 ------------------ 1 file changed, 144 deletions(-) delete mode 100644 build/pkgs/nauty/patches/nauty-2.8.6-gentreeg-gentourng.patch diff --git a/build/pkgs/nauty/patches/nauty-2.8.6-gentreeg-gentourng.patch b/build/pkgs/nauty/patches/nauty-2.8.6-gentreeg-gentourng.patch deleted file mode 100644 index 322b25326ee..00000000000 --- a/build/pkgs/nauty/patches/nauty-2.8.6-gentreeg-gentourng.patch +++ /dev/null @@ -1,144 +0,0 @@ -From edb0474a4db8e69f971e4eebe18716309f5a7bb3 Mon Sep 17 00:00:00 2001 -From: Michael Orlitzky -Date: Tue, 17 Jan 2023 19:44:49 -0500 -Subject: [PATCH 1/1] Upstream fixes for gentreeg and gentourng. - -https://mailman.anu.edu.au/pipermail/nauty/2023-January/000903.html ---- - gentourng.c | 2 +- - gentreeg.c | 95 ++++++++++++++++++++++++++++------------------------- - 2 files changed, 51 insertions(+), 46 deletions(-) - -diff --git a/gentourng.c b/gentourng.c -index 634e5e8..5c7ffff 100644 ---- a/gentourng.c -+++ b/gentourng.c -@@ -1408,7 +1408,7 @@ PLUGIN_INIT - (*outproc)(outfile,g,1); - } - } -- else -+ else if (!connec || maxn != 2) - { - makeleveldata(); - -diff --git a/gentreeg.c b/gentreeg.c -index 946d5f8..15bf87b 100644 ---- a/gentreeg.c -+++ b/gentreeg.c -@@ -1,4 +1,4 @@ --/* gentree version 1.3; Brendan McKay Oct 2022 */ -+/* gentree version 1.4; Brendan McKay Dec 2022 */ - /* This program is a wrapper for the program FreeTrees.c written - * by Gang Li & Frank Ruskey. See below for their original - * comments. */ -@@ -32,49 +32,54 @@ Counts for n=1..45: - 1: 1 - 2: 1 - 3: 1 -- 4: 1 -- 5: 2 -- 6: 3 -- 7: 6 -- 8: 11 -- 9: 23 --10: 47 --11: 106 --12: 235 --13: 551 --14: 1301 --15: 3159 --16: 7741 --17: 19320 --18: 48629 --19: 123867 --20: 317955 --21: 823065 --22: 2144505 --23: 5623756 --24: 14828074 --25: 39299897 --26: 104636890 --27: 279793450 --28: 751065460 --29: 2023443032 --30: 5469566585 --31: 14830871802 --32: 40330829030 --33: 109972410221 --34: 300628862480 --35: 823779631721 --36: 2262366343746 --37: 6226306037178 --38: 17169677490714 --39: 47436313524262 --40: 131290543779126 --41: 363990257783343 --42: 1010748076717151 --43: 2810986483493475 --44: 7828986221515605 --45: 21835027912963086 --********************************/ -+ 4: 2 -+ 5: 3 -+ 6: 6 -+ 7: 11 -+ 8: 23 -+ 9: 47 -+10: 106 -+11: 235 -+12: 551 -+13: 1301 -+14: 3159 -+15: 7741 -+16: 19320 -+17: 48629 -+18: 123867 -+19: 317955 -+20: 823065 -+21: 2144505 -+22: 5623756 -+23: 14828074 -+24: 39299897 -+25: 104636890 -+26: 279793450 -+27: 751065460 -+28: 2023443032 -+29: 5469566585 -+30: 14830871802 -+31: 40330829030 -+32: 109972410221 -+33: 300628862480 -+34: 823779631721 -+35: 2262366343746 -+36: 6226306037178 -+37: 17169677490714 -+38: 47436313524262 -+39: 131290543779126 -+40: 363990257783343 -+41: 1010748076717151 -+42: 2810986483493475 -+43: 7828986221515605 -+44: 21835027912963086 -+45: 60978390985918906 -+46: 170508699155987862 -+47: 477355090753926460 -+48: 1337946100045842285 -+49: 3754194185716399992 -+50: 10545233702911509534 -+*******************************/ - - /* Comments on original program by original authors */ - /*==============================================================*/ -@@ -676,7 +681,7 @@ PLUGIN_INIT - } - else if (nv == 2) - { -- if (res == 0 && maxdeg >= 1 && mindiam <= 1 && maxdiam >= 2) -+ if (res == 0 && maxdeg >= 1 && mindiam <= 1 && maxdiam >= 1) - { - par[1] = 0; - par[2] = 1; --- -2.38.2 - From 6f75a40a69e9d4060b16bb6aee4bb630a1333d80 Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sun, 26 Nov 2023 11:57:22 -0800 Subject: [PATCH 3/7] sage -package: Substitute VERSION_MAJOR, ${VERSION_MINOR}, etc. like VERSION --- build/sage_bootstrap/package.py | 73 +++++++++++++++++++++++++++++- src/doc/en/developer/packaging.rst | 6 ++- 2 files changed, 75 insertions(+), 4 deletions(-) diff --git a/build/sage_bootstrap/package.py b/build/sage_bootstrap/package.py index f6a5425005a..43bfbffa47c 100644 --- a/build/sage_bootstrap/package.py +++ b/build/sage_bootstrap/package.py @@ -121,6 +121,42 @@ def tarball(self): self.__tarball = Tarball(self.tarball_filename, package=self) return self.__tarball + def _substitute_variables_once(self, pattern): + """ + Substitute (at most) one occurrence of variables in ``pattern`` by the values. + + These variables are ``VERSION``, ``VERSION_MAJOR``, ``VERSION_MINOR``, + ``VERSION_MICRO``, either appearing like this or in the form ``${VERSION_MAJOR}`` + etc. + + Return a tuple: + - the string with the substitution done or the original string + - whether a substitution was done + """ + for var in ('VERSION_MAJOR', 'VERSION_MINOR', 'VERSION_MICRO', 'VERSION'): + # As VERSION is a substring of the other three, it needs to be tested last. + dollar_brace_var = '${' + var + '}' + if dollar_brace_var in pattern: + value = getattr(self, var.lower()) + return pattern.replace(dollar_brace_var, value, 1), True + elif var in pattern: + value = getattr(self, var.lower()) + return pattern.replace(var, value, 1), True + return pattern, False + + def _substitute_variables(self, pattern): + """ + Substitute all occurrences of ``VERSION`` in ``pattern`` by the actual version. + + Likewise for ``VERSION_MAJOR``, ``VERSION_MINOR``, ``VERSION_MICRO``, + either appearing like this or in the form ``${VERSION}``, ``${VERSION_MAJOR}``, + etc. + """ + not_done = True + while not_done: + pattern, not_done = self._substitute_variables_once(pattern) + return pattern + @property def tarball_pattern(self): """ @@ -150,7 +186,7 @@ def tarball_filename(self): """ pattern = self.tarball_pattern if pattern: - return pattern.replace('VERSION', self.version) + return self._substitute_variables(pattern) else: return None @@ -177,7 +213,7 @@ def tarball_upstream_url(self): """ pattern = self.tarball_upstream_url_pattern if pattern: - return pattern.replace('VERSION', self.version) + return self._substitute_variables(pattern) else: return None @@ -212,6 +248,39 @@ def version(self): """ return self.__version + @property + def version_major(self): + """ + Return the major version + + OUTPUT: + + String. The package's major version. + """ + return self.version.split('.')[0] + + @property + def version_minor(self): + """ + Return the minor version + + OUTPUT: + + String. The package's minor version. + """ + return self.version.split('.')[1] + + @property + def version_micro(self): + """ + Return the micro version + + OUTPUT: + + String. The package's micro version. + """ + return self.version.split('.')[2] + @property def patchlevel(self): """ diff --git a/src/doc/en/developer/packaging.rst b/src/doc/en/developer/packaging.rst index 9f8bd2528ef..c82531c779c 100644 --- a/src/doc/en/developer/packaging.rst +++ b/src/doc/en/developer/packaging.rst @@ -1052,9 +1052,11 @@ Sage mirrors when a new release is prepared. On GitHub PRs upgrading a package, the PR description should no longer contain the upstream URL to avoid duplication of information. -Note that, like the ``tarball`` field, the ``tpstream_url`` is a +Note that, like the ``tarball`` field, the ``upstream_url`` is a template; the substring ``VERSION`` is substituted with the actual -version. +version. It can also be written as ``${VERSION}``, and it is possible +to refer to the dot-separated components of a version by ``VERSION_MAJOR``, +``VERSION_MINOR``, and ``VERSION_MICRO``. For Python packages available from PyPI, you should use an ``upstream_url`` from ``pypi.io``, which follows the format From bf0d3143ceb80ba1692d9feee1a241dc8e99ed0e Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sun, 26 Nov 2023 11:58:06 -0800 Subject: [PATCH 4/7] build/pkgs/nauty/checksums.ini: Update for actual 2.8.8 tarball, use ${VERSION_MAJOR} etc. --- build/pkgs/nauty/checksums.ini | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build/pkgs/nauty/checksums.ini b/build/pkgs/nauty/checksums.ini index a9dd1246e91..f699a05e9fc 100644 --- a/build/pkgs/nauty/checksums.ini +++ b/build/pkgs/nauty/checksums.ini @@ -1,5 +1,5 @@ -tarball=nautyVERSION.tar.gz -sha1=10c39117c55c69c18c6a107110e7c08f3d873652 -md5=7a82f4209f5d552da3078c67e5af872e -cksum=2164796643 -upstream_url=https://pallini.di.uniroma1.it/nauty2_8_6.tar.gz +tarball=nauty${VERSION}.tar.gz +sha1=672e9fc9dfd07201af37ee65807a9b493331ed92 +md5=16c6edc1a8747c9281041b7c7092135f +cksum=2663136901 +upstream_url=https://pallini.di.uniroma1.it/nauty${VERSION_MAJOR}_${VERSION_MINOR}_${VERSION_MICRO}.tar.gz From d5caf09e60192e2aa8b344652523f12113dbe85f Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sun, 26 Nov 2023 13:06:46 -0800 Subject: [PATCH 5/7] build/pkgs/*/checksums.ini: Use VERSION in all upstream urls --- build/pkgs/4ti2/checksums.ini | 4 ++-- build/pkgs/cunningham_tables/checksums.ini | 2 +- build/pkgs/gf2x/checksums.ini | 2 +- build/pkgs/graphs/checksums.ini | 2 +- build/pkgs/kenzo/checksums.ini | 4 ++-- build/pkgs/planarity/checksums.ini | 2 +- build/pkgs/plantri/checksums.ini | 4 ++-- build/pkgs/polytopes_db_4d/checksums.ini | 2 +- build/pkgs/sqlite/checksums.ini | 4 ++-- build/pkgs/symmetrica/checksums.ini | 2 +- build/pkgs/sympow/checksums.ini | 2 +- 11 files changed, 15 insertions(+), 15 deletions(-) diff --git a/build/pkgs/4ti2/checksums.ini b/build/pkgs/4ti2/checksums.ini index 275cf157a6a..047f39ece1d 100644 --- a/build/pkgs/4ti2/checksums.ini +++ b/build/pkgs/4ti2/checksums.ini @@ -1,5 +1,5 @@ -tarball=4ti2-VERSION.tar.gz +tarball=4ti2-${VERSION}.tar.gz sha1=3d41f30ea3ef94c293eae30c087494269fc1a6b9 md5=1215872325ddfc561865ecb22b2bccb2 cksum=2439180289 -upstream_url=https://github.com/4ti2/4ti2/releases/download/Release_1_6_10/4ti2-1.6.10.tar.gz +upstream_url=https://github.com/4ti2/4ti2/releases/download/Release_${VERSION_MAJOR}_${VERSION_MINOR}_${VERSION_MICRO}/4ti2-${VERSION}.tar.gz diff --git a/build/pkgs/cunningham_tables/checksums.ini b/build/pkgs/cunningham_tables/checksums.ini index d6de22c0850..360d9b647b7 100644 --- a/build/pkgs/cunningham_tables/checksums.ini +++ b/build/pkgs/cunningham_tables/checksums.ini @@ -2,4 +2,4 @@ tarball=cunningham_tables-VERSION.tar.gz sha1=8bea1a113d85bb9c37d8f213dd19525d9d026f22 md5=e71b32f12e9a46c1c86e275e8441a06b cksum=1990403877 -upstream_url=http://users.ox.ac.uk/~coml0531/sage/cunningham_tables-1.0.tar.gz +upstream_url=http://users.ox.ac.uk/~coml0531/sage/cunningham_tables-VERSION.tar.gz diff --git a/build/pkgs/gf2x/checksums.ini b/build/pkgs/gf2x/checksums.ini index 10a93c2c1bc..0eaf7657e40 100644 --- a/build/pkgs/gf2x/checksums.ini +++ b/build/pkgs/gf2x/checksums.ini @@ -2,4 +2,4 @@ tarball=gf2x-VERSION.tar.gz sha1=1b9c7e14031afc5488b9aa27f5501f78c90f00b4 md5=842f087ce423c279dced26b85b0fd1d0 cksum=3368093312 -upstream_url=https://gitlab.inria.fr/gf2x/gf2x/uploads/c46b1047ba841c20d1225ae73ad6e4cd/gf2x-1.3.0.tar.gz +upstream_url=https://gitlab.inria.fr/gf2x/gf2x/uploads/c46b1047ba841c20d1225ae73ad6e4cd/gf2x-VERSION.tar.gz diff --git a/build/pkgs/graphs/checksums.ini b/build/pkgs/graphs/checksums.ini index 285778ef3a7..7ec4a8a6ada 100644 --- a/build/pkgs/graphs/checksums.ini +++ b/build/pkgs/graphs/checksums.ini @@ -2,4 +2,4 @@ tarball=graphs-VERSION.tar.bz2 sha1=c3b9fcbc92482efd6b7f6f3a33df5a78e1256aa1 md5=4357919410e8ac2611c9fe643976c8ff cksum=2340933149 -upstream_url=http://users.ox.ac.uk/~coml0531/sage/graphs-20210214.tar.bz2 +upstream_url=http://users.ox.ac.uk/~coml0531/sage/graphs-VERSION.tar.bz2 diff --git a/build/pkgs/kenzo/checksums.ini b/build/pkgs/kenzo/checksums.ini index ad2a7c4cc60..7fff82ca271 100644 --- a/build/pkgs/kenzo/checksums.ini +++ b/build/pkgs/kenzo/checksums.ini @@ -1,5 +1,5 @@ -tarball=kenzo-1.1.10.tar.gz -upstream_url=https://github.com/miguelmarco/kenzo/releases/download/1.1.10/kenzo-1.1.10.tar.gz +tarball=kenzo-VERSION.tar.gz +upstream_url=https://github.com/miguelmarco/kenzo/releases/download/VERSION/kenzo-VERSION.tar.gz sha1=76115aae9972090d5d51fee18592fc7a79461474 md5=3a3d5350fb17304f03e614713e585ed4 cksum=2981306888 diff --git a/build/pkgs/planarity/checksums.ini b/build/pkgs/planarity/checksums.ini index 6227637695a..309daa93278 100644 --- a/build/pkgs/planarity/checksums.ini +++ b/build/pkgs/planarity/checksums.ini @@ -2,4 +2,4 @@ tarball=planarity-VERSION.tar.gz sha1=8407bccf33c07bf0dae22d79b5e6ac7d89c62ea3 md5=200116e6a67544c8e94f9de7c3ba1b1a cksum=4207261512 -upstream_url=http://users.ox.ac.uk/~coml0531/sage/planarity-3.0.1.0.tar.gz +upstream_url=http://users.ox.ac.uk/~coml0531/sage/planarity-VERSION.tar.gz diff --git a/build/pkgs/plantri/checksums.ini b/build/pkgs/plantri/checksums.ini index 05dc13d01e7..f999a981a69 100644 --- a/build/pkgs/plantri/checksums.ini +++ b/build/pkgs/plantri/checksums.ini @@ -1,5 +1,5 @@ -tarball=plantri53.tar.gz +tarball=plantri${VERSION_MAJOR}${VERSION_MINOR}.tar.gz sha1=a04aec2fa90c43f1c9bef59d041a54d8fa5bf562 md5=ea765b3508dd56384f94ad1f032e2dd4 cksum=3200215885 -upstream_url=https://users.cecs.anu.edu.au/~bdm/plantri/plantri53.tar.gz +upstream_url=https://users.cecs.anu.edu.au/~bdm/plantri/plantri${VERSION_MAJOR}${VERSION_MINOR}.tar.gz diff --git a/build/pkgs/polytopes_db_4d/checksums.ini b/build/pkgs/polytopes_db_4d/checksums.ini index edfee6b7841..d87e456c4a8 100644 --- a/build/pkgs/polytopes_db_4d/checksums.ini +++ b/build/pkgs/polytopes_db_4d/checksums.ini @@ -2,4 +2,4 @@ tarball=polytopes_db_4d-VERSION.spkg sha1=c9779821e365df2d7f9bc684f9e2ec0e95fb8650 md5=fe775a26fd7b2afc187e9bfabfb1b86a cksum=3415837678 -upstream_url=http://ftp.sparcs.org/sage/spkg/huge/polytopes_db_4d-1.0.spkg +upstream_url=http://ftp.sparcs.org/sage/spkg/huge/polytopes_db_4d-VERSION.spkg diff --git a/build/pkgs/sqlite/checksums.ini b/build/pkgs/sqlite/checksums.ini index 5cb33394ab3..777aa3953a3 100644 --- a/build/pkgs/sqlite/checksums.ini +++ b/build/pkgs/sqlite/checksums.ini @@ -1,5 +1,5 @@ -tarball=sqlite-autoconf-3360000.tar.gz +tarball=sqlite-autoconf-${VERSION_MAJOR}${VERSION_MINOR}0${VERSION_MICRO}00.tar.gz sha1=a4bcf9e951bfb9745214241ba08476299fc2dc1e md5=f5752052fc5b8e1b539af86a3671eac7 cksum=763219165 -upstream_url=https://www.sqlite.org/2021/sqlite-autoconf-3360000.tar.gz +upstream_url=https://www.sqlite.org/2021/sqlite-autoconf-${VERSION_MAJOR}${VERSION_MINOR}0${VERSION_MICRO}00.tar.gz diff --git a/build/pkgs/symmetrica/checksums.ini b/build/pkgs/symmetrica/checksums.ini index 5f70ed5363c..6d06ebda462 100644 --- a/build/pkgs/symmetrica/checksums.ini +++ b/build/pkgs/symmetrica/checksums.ini @@ -2,4 +2,4 @@ tarball=symmetrica-VERSION.tar.xz sha1=0044cc087ff04267c246e730c6570d89f6e593af md5=cd4716c26b5c625a012c22656113ef6f cksum=1186250347 -upstream_url=http://users.ox.ac.uk/~coml0531/sage/symmetrica-3.0.1.tar.xz +upstream_url=http://users.ox.ac.uk/~coml0531/sage/symmetrica-VERSION.tar.xz diff --git a/build/pkgs/sympow/checksums.ini b/build/pkgs/sympow/checksums.ini index f6ad79b8f93..87bf0086178 100644 --- a/build/pkgs/sympow/checksums.ini +++ b/build/pkgs/sympow/checksums.ini @@ -2,4 +2,4 @@ tarball=sympow-vVERSION.tar.gz sha1=37a909c26009415197b5088a2f1b53dd3558f494 md5=51f2c717c84ec9c2840af740751cf797 cksum=1444149964 -upstream_url=https://github.com/mkoeppe/sympow/releases/download/v2.023.6/sympow-v2.023.6.tar.gz +upstream_url=https://github.com/mkoeppe/sympow/releases/download/vVERSION/sympow-vVERSION.tar.gz From aaa1e36dbdc2acc174e81b93e2ab09e6e5040c5d Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Sun, 26 Nov 2023 14:30:42 -0800 Subject: [PATCH 6/7] build/bin/sage-spkg: Use 'sage-package download' instead of lower-level 'sage-download-file' --- build/bin/sage-spkg | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/build/bin/sage-spkg b/build/bin/sage-spkg index b540c8e866f..52c2df2fbc8 100755 --- a/build/bin/sage-spkg +++ b/build/bin/sage-spkg @@ -311,7 +311,7 @@ else PKG_NAME="${PKG_BASE}-${PKG_VER}" fi PKG_BASE_VER=`echo $PKG_VER | sed 's/\.p[0-9][0-9]*$//'` -PKG_NAME_UPSTREAM=`lookup_param tarball "$PKG_SCRIPTS/checksums.ini" | sed "s/VERSION/$PKG_BASE_VER/"` +PKG_NAME_UPSTREAM=`lookup_param tarball "$PKG_SCRIPTS/checksums.ini"` # Warning for experimental packages if [ x`cat "$PKG_SCRIPTS/type"` = x"experimental" -a $INFO = 0 ]; then @@ -353,11 +353,11 @@ fi if [ ! -f "$PKG_SRC" ]; then if [ -n "$PKG_NAME_UPSTREAM" ]; then # This is the new-style package way of downloading the tarball - if ! sage-download-file $SAGE_DOWNLOAD_FILE_OPTIONS "$PKG_NAME_UPSTREAM"; then - error_msg "Error downloading $PKG_NAME_UPSTREAM" + PKG_SRC=$(sage-package download $SAGE_DOWNLOAD_FILE_OPTIONS $PKG_BASE) + if [ $? != 0 ]; then + error_msg "Error downloading tarball of $PKG_BASE" exit 1 fi - PKG_SRC="$SAGE_DISTFILES/$PKG_NAME_UPSTREAM" else echo >&2 "Error: Installing old-style SPKGs is no longer supported" exit 1 From 0ccbb06d5a8efa2b9e1aa7cf0b9149a59ef38729 Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Mon, 27 Nov 2023 20:15:26 -0800 Subject: [PATCH 7/7] sage --package update: Display upstream URL and warn if upstream_url pattern does not use the VERSION variable --- build/sage_bootstrap/updater.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build/sage_bootstrap/updater.py b/build/sage_bootstrap/updater.py index 7c1431967a1..67f1c961124 100644 --- a/build/sage_bootstrap/updater.py +++ b/build/sage_bootstrap/updater.py @@ -69,8 +69,11 @@ def _update_version(self, new_version): def download_upstream(self, download_url=None): tarball = self.package.tarball if download_url is None: + pattern = self.package.tarball_upstream_url_pattern + if pattern and 'VERSION' not in pattern: + print('Warning: upstream_url pattern does not use the VERSION variable') download_url = self.package.tarball_upstream_url if download_url is None: raise ValueError("package has no default upstream_url pattern, download_url needed") - print('Downloading tarball to {0}'.format(tarball.upstream_fqn)) + print('Downloading tarball from {0} to {1}'.format(download_url, tarball.upstream_fqn)) Download(download_url, tarball.upstream_fqn).run()