Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker manifest schema 1 is not yet supported #2

Closed
leogr opened this issue Jul 1, 2019 · 1 comment
Closed

Docker manifest schema 1 is not yet supported #2

leogr opened this issue Jul 1, 2019 · 1 comment
Assignees
@leogr
Labels
wontfix This will not be worked on

Comments

@leogr
Copy link
Contributor

leogr commented Jul 1, 2019

https://github.com/vchain-us/kube-notary/blob/dc557c7ca02f6bc6f47fc8dd1faa414318140201/pkg/image/resolve.go#L72

Currently, quay.io images won't work for this reason.
@leogr leogr added the enhancement New feature or request label Jul 1, 2019
@leogr leogr self-assigned this Jul 1, 2019
@leogr leogr added wontfix This will not be worked on and removed enhancement New feature or request labels Aug 28, 2019
@leogr
Copy link
Contributor Author

leogr commented Aug 28, 2019

We're going to not support the now deprecated manifest v2 schema 1.

https://docs.docker.com/engine/deprecated/#pushing-and-pulling-with-image-manifest-v2-schema-1

leogr added a commit that referenced this issue Aug 28, 2019
@leogr
fix: skip not addressable images by bulk signing
eb83618 
#2
@leogr leogr closed this as completed in 5408795 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leogr leogr

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leogr