Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report progress of long operations like git clone or git update #9

Closed
jcfr opened this issue Jun 21, 2016 · 3 comments
Closed

Report progress of long operations like git clone or git update #9

jcfr opened this issue Jun 21, 2016 · 3 comments
Assignees
@tony

Comments

@jcfr
Copy link
Collaborator

jcfr commented Jun 21, 2016

It is convenient for used of the libvcs to (optionally) be able to report progress.

It used to be reported with vcspull, which approach would you recommend to "restore" this behavior ?

I was initially thinking about having a report_progress_callback parameter initially set to None
@tony
Copy link
Member

tony commented Jun 21, 2016 •
edited
Loading

@jcfr

An aside: I was wrestling the issue here https://github.com/tony/libvcs/compare/log-progress-refactor, which replaced run_buffered (what put the current progress to stdout) with a spinner. But opted to rip it sound to make the codebase simpler.

I'm for 👍 for adding an optional callback.

@tony tony self-assigned this Jun 22, 2016
tony added a commit that referenced this issue Jun 22, 2016
@tony
Use google's shell_utils for callbacks/async #9
c18d11b 
Add callback suppport, cwd, lower sleep time.
@tony tony mentioned this issue Jun 22, 2016
Merged
tony added a commit that referenced this issue Jun 23, 2016
@tony
Use google's shell_utils for callbacks/async #9
9719bd9 
Add callback suppport, cwd, lower sleep time.
tony added a commit that referenced this issue Jun 24, 2016
@tony
Add callback for progress, refactor utils, test #9
a9739a4 
- Move RepoLoggingAdapter to util
- Add progress_callback property to repos, refactor Command errors
- refactor git fixture names, add callback test
- remove mock in requirements.txt
- travis.yml: update mock in prereq due to travis env issue
- refactor CommandError exception to show details
- Fix get_revision file for svn and test
- refactor fixture names
- Remove unused repo not found test
- Add pytest-raisesregexp until pytest 2.10.0 is released
- tweak bootstrap_env a bit
- initial tests for base abstract class, __repr__ py2/3
- test exceptions
- adjust update_repo order for mercurial
- remove unused which code
- Add test_util and add testcase for mkdir_p
- More tests for git, initial tests / mocks for update
- support pypy3, test CI with pypy and pypy3
- test mkdir_p on an already existing dir
- document progress_callback function
@tony
Copy link
Member

tony commented Jun 24, 2016

@jcfr libvcs 0.2.0 is up

usage for callback at http://libvcs.readthedocs.io/en/latest/api.html#libvcs.util.run

test at https://github.com/tony/libvcs/blob/a9739a4/tests/test_git.py#L75

another example on vcspull @ https://github.com/tony/vcspull/blob/394e49f/vcspull/cli.py#L114

@jcfr
Copy link
Collaborator Author

jcfr commented Jun 25, 2016

Thanks @tony

Works great.

I just updated pys4ext: jcfr/pys4ext@e0fe090

@jcfr jcfr closed this as completed Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tony tony

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tony @jcfr