From 84397905228faacce39118b7a30e77c8cbc73338 Mon Sep 17 00:00:00 2001 From: Ken Rachynski Date: Tue, 18 Jun 2024 11:47:48 -0600 Subject: [PATCH 1/2] Stop adding Description fixes #257 This code was adding the AzureSignTool project description to the signed file. Sending null allows the codesigning to reuse the existing description. --- src/AzureSignTool/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AzureSignTool/Program.cs b/src/AzureSignTool/Program.cs index 2f8ed58..9bd02c0 100644 --- a/src/AzureSignTool/Program.cs +++ b/src/AzureSignTool/Program.cs @@ -317,7 +317,7 @@ private async ValueTask RunSign() return (state.succeeded + 1, state.failed); } - var result = signer.SignFile(filePath, Description, SignDescriptionUrl, performPageHashing, logger, appendSignature); + var result = signer.SignFile(filePath, null, SignDescriptionUrl, performPageHashing, logger, appendSignature); switch (result) { case COR_E_BADIMAGEFORMAT: From 243dce0d885d6f91697b5e0e80e2bb0103495ca2 Mon Sep 17 00:00:00 2001 From: Ken Rachynski Date: Thu, 22 Aug 2024 09:43:57 -0600 Subject: [PATCH 2/2] Update src/AzureSignTool/Program.cs Co-authored-by: Nathan Hess <167568967+nathan-hess-dmc@users.noreply.github.com> --- src/AzureSignTool/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AzureSignTool/Program.cs b/src/AzureSignTool/Program.cs index 9bd02c0..0632153 100644 --- a/src/AzureSignTool/Program.cs +++ b/src/AzureSignTool/Program.cs @@ -317,7 +317,7 @@ private async ValueTask RunSign() return (state.succeeded + 1, state.failed); } - var result = signer.SignFile(filePath, null, SignDescriptionUrl, performPageHashing, logger, appendSignature); + var result = signer.SignFile(filePath, SignDescription, SignDescriptionUrl, performPageHashing, logger, appendSignature); switch (result) { case COR_E_BADIMAGEFORMAT: