From 6ace7617b96a859bc6c0bd39e6c4e08d890a82cd Mon Sep 17 00:00:00 2001 From: ykadowak Date: Fri, 8 Mar 2024 04:50:17 +0000 Subject: [PATCH] Refactor rotateIfNeeded function to use label selector for listing deployments --- pkg/index/operator/service/operator.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/pkg/index/operator/service/operator.go b/pkg/index/operator/service/operator.go index 28d58e88e6..78b5270e38 100644 --- a/pkg/index/operator/service/operator.go +++ b/pkg/index/operator/service/operator.go @@ -181,8 +181,15 @@ func (o *operator) rotateIfNeeded(ctx context.Context, pod pod.Pod) error { } var depList client.DeploymentList - label := client.MatchingLabels(map[string]string{o.readReplicaLabelKey: podIdx}) - if err := o.client.List(ctx, &depList, label); err != nil { + selector, err := o.client.LabelSelector(o.readReplicaLabelKey, client.SelectionOpEquals, []string{podIdx}) + if err != nil { + return fmt.Errorf("creating label selector: %w", err) + } + listOpts := client.ListOptions{ + Namespace: o.namespace, + LabelSelector: selector, + } + if err := o.client.List(ctx, &depList, &listOpts); err != nil { return err } if len(depList.Items) == 0 {