From 728f12d164087ca2dc90a45a77bea6913a2a0c04 Mon Sep 17 00:00:00 2001 From: ykadowak Date: Thu, 8 Feb 2024 07:57:57 +0000 Subject: [PATCH] Update Dockerfile to use official debian based image for devcontainer --- dockers/dev/Dockerfile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dockers/dev/Dockerfile b/dockers/dev/Dockerfile index 30449e7ad83..1029dd6e99d 100644 --- a/dockers/dev/Dockerfile +++ b/dockers/dev/Dockerfile @@ -18,7 +18,10 @@ ARG MAINTAINER="vdaas.org vald team " # skipcq: DOK-DL3026 -FROM --platform=${BUILDPLATFORM} ubuntu:devel AS builder +# Ubuntu is not supported by a lot of devcontainer features like `docker-in-docker`, so we should stick to official debian based ones +# https://github.com/devcontainers/features/blob/08fb370a59cc311d9f81a9e90be33cf2e6648baa/src/docker-in-docker/install.sh#L123 +# FIXME: change the tag to :1 when they support go 1.22 +FROM --platform=${BUILDPLATFORM} mcr.microsoft.com/vscode/devcontainers/go:dev-1.22 AS builder LABEL maintainer="${MAINTAINER}" ARG GO_VERSION