From fd7e8806b99e651d29fa02d7d72760d5e4d2e026 Mon Sep 17 00:00:00 2001 From: ykadowak Date: Thu, 30 Nov 2023 02:49:18 +0000 Subject: [PATCH] Revert "change default creation poolsize (#2190)" This reverts commit ff4a2a27a6482e01fd4562ab03cfd8ab185ae104. --- charts/vald/README.md | 6 +++--- charts/vald/values.yaml | 6 +++--- k8s/agent/configmap.yaml | 4 ++-- k8s/manager/index/configmap.yaml | 2 +- k8s/manager/index/deployment.yaml | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/charts/vald/README.md b/charts/vald/README.md index 41123979e4..aa696ad152 100644 --- a/charts/vald/README.md +++ b/charts/vald/README.md @@ -68,7 +68,7 @@ Run the following command to install the chart, | agent.maxUnavailable | string | `"1"` | maximum number of unavailable replicas | | agent.minReplicas | int | `20` | minimum number of replicas. if HPA is disabled, the replicas will be set to this value | | agent.name | string | `"vald-agent-ngt"` | name of agent deployment | -| agent.ngt.auto_create_index_pool_size | int | `16` | batch process pool size of automatic create index operation | +| agent.ngt.auto_create_index_pool_size | int | `10000` | batch process pool size of automatic create index operation | | agent.ngt.auto_index_check_duration | string | `"30m"` | check duration of automatic indexing | | agent.ngt.auto_index_duration_limit | string | `"24h"` | limit duration of automatic indexing | | agent.ngt.auto_index_length | int | `100` | number of cache to trigger automatic indexing | @@ -77,7 +77,7 @@ Run the following command to install the chart, | agent.ngt.bulk_insert_chunk_size | int | `10` | bulk insert chunk size | | agent.ngt.creation_edge_size | int | `20` | creation edge size | | agent.ngt.default_epsilon | float | `0.1` | default epsilon used for search | -| agent.ngt.default_pool_size | int | `16` | default create index batch pool size | +| agent.ngt.default_pool_size | int | `10000` | default create index batch pool size | | agent.ngt.default_radius | float | `-1` | default radius used for search | | agent.ngt.dimension | int | `4096` | vector dimension | | agent.ngt.distance_type | string | `"l2"` | distance type. it should be `l1`, `l2`, `angle`, `hamming`, `cosine`,`poincare`, `lorentz`, `jaccard`, `sparsejaccard`, `normalizedangle` or `normalizedcosine`. for further details about NGT libraries supported distance is https://github.com/yahoojapan/NGT/wiki/Command-Quick-Reference and vald agent's supported NGT distance type is https://pkg.go.dev/github.com/vdaas/vald/internal/core/algorithm/ngt#pkg-constants | @@ -716,7 +716,7 @@ Run the following command to install the chart, | manager.index.indexer.auto_save_index_duration_limit | string | `"3h"` | limit duration of automatic index saving | | manager.index.indexer.auto_save_index_wait_duration | string | `"10m"` | duration of automatic index saving wait duration for next saving | | manager.index.indexer.concurrency | int | `1` | concurrency | -| manager.index.indexer.creation_pool_size | int | `16` | number of pool size of create index processing | +| manager.index.indexer.creation_pool_size | int | `10000` | number of pool size of create index processing | | manager.index.indexer.discoverer.agent_client_options | object | `{"dial_option":{"net":{"dialer":{"keepalive":"15m"}}}}` | gRPC client options for agents (overrides defaults.grpc.client) | | manager.index.indexer.discoverer.client | object | `{}` | gRPC client for discoverer (overrides defaults.grpc.client) | | manager.index.indexer.discoverer.duration | string | `"500ms"` | refresh duration to discover | diff --git a/charts/vald/values.yaml b/charts/vald/values.yaml index 5a560c7d45..a1221ee74e 100644 --- a/charts/vald/values.yaml +++ b/charts/vald/values.yaml @@ -1652,7 +1652,7 @@ agent: auto_save_index_duration: 35m # @schema {"name": "agent.ngt.auto_create_index_pool_size", "type": "integer"} # agent.ngt.auto_create_index_pool_size -- batch process pool size of automatic create index operation - auto_create_index_pool_size: 16 + auto_create_index_pool_size: 10000 # @schema {"name": "agent.ngt.initial_delay_max_duration", "type": "string"} # agent.ngt.initial_delay_max_duration -- maximum duration for initial delay initial_delay_max_duration: 3m @@ -1684,7 +1684,7 @@ agent: enable_in_memory_mode: true # @schema {"name": "agent.ngt.default_pool_size", "type": "integer"} # agent.ngt.default_pool_size -- default create index batch pool size - default_pool_size: 16 + default_pool_size: 10000 # @schema {"name": "agent.ngt.default_radius", "type": "number"} # agent.ngt.default_radius -- default radius used for search default_radius: -1.0 @@ -2615,7 +2615,7 @@ manager: auto_index_length: 100 # @schema {"name": "manager.index.indexer.creation_pool_size", "type": "integer"} # manager.index.indexer.creation_pool_size -- number of pool size of create index processing - creation_pool_size: 16 + creation_pool_size: 10000 # @schema {"name": "manager.index.indexer.discoverer", "type": "object"} discoverer: # @schema {"name": "manager.index.indexer.discoverer.duration", "type": "string"} diff --git a/k8s/agent/configmap.yaml b/k8s/agent/configmap.yaml index 0bf98a9f90..cd6ddbe86b 100644 --- a/k8s/agent/configmap.yaml +++ b/k8s/agent/configmap.yaml @@ -199,7 +199,7 @@ data: trace: enabled: false ngt: - auto_create_index_pool_size: 16 + auto_create_index_pool_size: 10000 auto_index_check_duration: 30m auto_index_duration_limit: 24h auto_index_length: 100 @@ -208,7 +208,7 @@ data: bulk_insert_chunk_size: 10 creation_edge_size: 20 default_epsilon: 0.1 - default_pool_size: 16 + default_pool_size: 10000 default_radius: -1 dimension: 784 distance_type: l2 diff --git a/k8s/manager/index/configmap.yaml b/k8s/manager/index/configmap.yaml index c41fd479cf..dbe218302a 100644 --- a/k8s/manager/index/configmap.yaml +++ b/k8s/manager/index/configmap.yaml @@ -369,4 +369,4 @@ data: auto_save_index_duration_limit: 3h auto_save_index_wait_duration: 10m auto_index_length: 100 - creation_pool_size: 16 + creation_pool_size: 10000 diff --git a/k8s/manager/index/deployment.yaml b/k8s/manager/index/deployment.yaml index d9595f99e5..60c8ea1126 100644 --- a/k8s/manager/index/deployment.yaml +++ b/k8s/manager/index/deployment.yaml @@ -47,7 +47,7 @@ spec: app.kubernetes.io/instance: release-name app.kubernetes.io/component: manager-index annotations: - checksum/configmap: 3c876729e6ddb5fbd3f6f4eb45d9a312568a3ec676382a51d83a0930a58f690d + checksum/configmap: 813d30c3db6d727286f767cc4b4542d36ca9d699688712b808dd4be414a6c3f6 profefe.com/enable: "true" profefe.com/port: "6060" profefe.com/service: vald-manager-index