Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Improve singleflight pacakge #577

Closed
hlts2 opened this issue Jul 13, 2020 · 2 comments
Closed

[Proposal] Improve singleflight pacakge #577

hlts2 opened this issue Jul 13, 2020 · 2 comments

Comments

@hlts2
Copy link
Collaborator

hlts2 commented Jul 13, 2020

Is your feature request related to a problem? Please describe.:

The current implementation uses sync.Mutex and map to cache objects.
Removing the lock logic will improve performance.

Describe the solution you'd like:

Since locks and unlocks occur frequently, replacing them with sync.Map can be made lock-free, which is considered to speed up the process.

Describe alternatives you've considered:

Change from sync.Mutex and map to sync.Map to cache object.

@hlts2 hlts2 self-assigned this Jul 13, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type/feature to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@vankichi
Copy link
Contributor

vankichi commented Aug 5, 2020

colse

@vankichi vankichi closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants