Use different copy for self verification #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy all refers to 'their' device for when you're verifying someone else. Update it to refer to your own devices in the case where you're verifying one of your own devices.
bmarty
approved these changes
Jul 4, 2021
|
oh, good point |
and tweak the other string more because it's not "each other" either
|
updated |
bmarty
reviewed
Jul 5, 2021
| var scanOtherCodeTitle: String | ||
| var compareEmojiSubtitle: String | ||
| if (state.isMe) { | ||
| scanCodeInstructions = host.stringProvider.getString(R.string.verification_scan_self_notice) |
There was a problem hiding this comment.
Sorry, I did not noticed it before, but there is no need to use host. here. It only useful if you want to use the host member from the Epoxy item DSL, for instance inside bottomSheetVerificationNoticeItem {} block.
It's not a big deal at all, it's OK to merge the PR like that, I can do the clean up later.
There was a problem hiding this comment.
ah - I see, I did wonder what that was all about, but figured it was best to be consistent anyhow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy all refers to 'their' device for when you're verifying
someone else. Update it to refer to your own devices in the case
where you're verifying one of your own devices.
Pull Request Checklist
Equivalent for iOS: element-hq/element-ios#4525