Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ShareCompat.IntentBuilder for sharing images #3965

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Use ShareCompat.IntentBuilder for sharing images #3965

merged 1 commit into from
Sep 6, 2021

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Sep 3, 2021 •
edited
Loading

Use ShareCompat.IntentBuilder for sharing images. ShareCompat does the right thing with URI permissions so image previews show up in the Share sheet of Android 11.

Before and after:

element__share_image__before element__share_image__after

Pull Request Checklist

Signed-off-by: cketti ck@cketti.de

@cketti
Use ShareCompat.IntentBuilder for sharing images
0aff0c1 
ShareCompat does the right things so image previews show up in the Share sheet of Android 11.
@cketti cketti marked this pull request as ready for review September 3, 2021 22:53
bmarty
bmarty approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty enabled auto-merge September 6, 2021 07:47
@bmarty bmarty merged commit e1f7ab8 into element-hq:develop Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cketti @bmarty