Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug MenuItem are always visible #4234

Closed
bmarty opened this issue Oct 13, 2021 · 0 comments · Fixed by #4236
Closed

Debug MenuItem are always visible #4234

bmarty opened this issue Oct 13, 2021 · 0 comments · Fixed by #4236
Assignees
@ouchadam
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint - Element ...

Comments

@bmarty
Copy link
Member

bmarty commented Oct 13, 2021

The 2 last menu item should be hidden by default but are always visible:

image

The code to hide them is here:
https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt#L502

But debugging it is very weird.

We should probably just remove those menu item, but it can be useful for future work on init sync perf improvement...
@bmarty bmarty added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 13, 2021
@bmarty bmarty added this to the Sprint - Element 1.3.3 milestone Oct 13, 2021
@ouchadam ouchadam self-assigned this Oct 13, 2021
@ouchadam ouchadam mentioned this issue Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint - Element 1.3.4
Development

Successfully merging a pull request may close this issue.

Fixing developer sync options always displaying element-hq/element-android
2 participants
@ouchadam @bmarty