Add privacy setting to disable personalized learning by the keyboard #6633
Conversation
Benjiko99
changed the title
| @@ -1522,6 +1522,8 @@ class TimelineFragment @Inject constructor( | |||
|
|
|||
| observerUserTyping() | |||
|
|
|||
| composerEditText.setUseIncognitoKeyboard(vectorPreferences.useIncognitoKeyboard()) | |||
There was a problem hiding this comment.
I am afraid that the imeOptions will be erased by the line 1530 just below, if vectorPreferences.sendMessageWithEnter() returns true.
Maybe on the same format than setUseIncognitoKeyboard create a new fun to (properly!) handle vectorPreferences.sendMessageWithEnter() setting.
| @@ -2539,6 +2539,9 @@ | |||
| <string name="settings_security_prevent_screenshots_title">Prevent screenshots of the application</string> | |||
| <string name="settings_security_prevent_screenshots_summary">Enabling this setting adds the FLAG_SECURE to all Activities. Restart the application for the change to take effect.</string> | |||
|
|
|||
| <string name="settings_security_incognito_keyboard_title">Incognito keyboard</string> | |||
| <string name="settings_security_incognito_keyboard_summary">Request that the keyboard should not update any personalized data such as typing history and dictionary based on what the user typed. Some keyboards may not respect this setting.</string> | |||
There was a problem hiding this comment.
Since the user is also the reader, it could be changed to
| <string name="settings_security_incognito_keyboard_summary">Request that the keyboard should not update any personalized data such as typing history and dictionary based on what the user typed. Some keyboards may not respect this setting.</string> | |
| <string name="settings_security_incognito_keyboard_summary">"Request that the keyboard should not update any personalized data such as typing history and dictionary based on what you've typed. Notice that some keyboards may not respect this setting."</string> |
Also I am wondering if we should mention that the setting will only applies to the message composer (and not for instance when editing a room topic, etc.). Since other entered texts are not e2e encrypted, this is maybe fine.
We could have
| <string name="settings_security_incognito_keyboard_summary">Request that the keyboard should not update any personalized data such as typing history and dictionary based on what the user typed. Some keyboards may not respect this setting.</string> | |
| <string name="settings_security_incognito_keyboard_summary">"When typing messages, request that the keyboard should not update any personalized data such as typing history and dictionary based on what you've typed. Notice that some keyboards may not respect this setting."</string> |
Another option would be to move this setting to the Settings/Preferences/Message editor section to mitigate this, but I think it's better to keep it in the Security & Privacy section.
|
Ping @Benjiko99 :-) |
|
All issues should be resolved now. |
Type of change
Content
A new option has been added to the Privacy settings, which requests that the keyboard should not update any personalized data such as typing history and dictionary based on what the user typed.
Motivation and context
Requesting that the keyboard minimize the amount of data it records about your private communications seems sensible for an encrypted messaging app.
It should disable the keyboard's personalized learning features, like adding your typed words into the personalized dictionary or storing the history of what you type. Some keyboards may not respect this setting. Signal messenger has this feature and missed it here.
Screenshots
Tests
Tested devices
Checklist