Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled verification requests flash up after opening app #4472

Closed
dbkr opened this issue Jun 24, 2021 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1210
Closed

Cancelled verification requests flash up after opening app #4472

dbkr opened this issue Jun 24, 2021 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1210
Assignees

Comments

@dbkr
Copy link
Member

dbkr commented Jun 24, 2021

  • Have an ios device logged in with element closed
  • Send a verification request to it (eg. log in with another device)
  • Cancel the verification request
  • Open element on ios

A verification request dialog appears briefly, then disappears.

Similar to element-hq/element-android#3563 on android, but less severe.

@dbkr dbkr self-assigned this Aug 13, 2021
@ShadowJonathan
Copy link
Contributor

I think this is because all to-device messages are sent to the device in batches? (And/or the device is firing event handlers on each individual one in sequence)

This should be easy to fix by iterating /sync with 0 timeout until the server returns no more to-device, handling them all in one batch, and only then displaying any potential "leftovers" to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants