Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXSession is paused after any sync request is legitimately cancelled #5509

Closed
Anderas opened this issue Feb 4, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1360
Closed

MXSession is paused after any sync request is legitimately cancelled #5509

Anderas opened this issue Feb 4, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1360
Assignees
@Anderas
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@Anderas
Copy link
Contributor

Anderas commented Feb 4, 2022 •
edited
Loading

MXSession is paused after any sync request is legitimately cancelled (e.g. a screen that triggered it deallocated), and there is no mechanism that resumes it whilst the app is in foreground. As a result, the app will stop recieving new messages from the server.

Steps to reproduce

  • navigate to a room B from a deeplink in room A
  • pull down to refresh in room B
  • before the refresh completes (1-2 seconds) navigate back to room A
  • at this point a URLRequest has been cancelled (correctly so, the screen that triggered it is gone), but that cancellation causes pausing of the whole MXSession
  • from here on no new messages will arrive unless you background / foreground the app
@Anderas Anderas self-assigned this Feb 4, 2022
This was referenced Feb 4, 2022
Closed
Merged
@Anderas Anderas added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not pause MXSession if a sync request is cancelled matrix-org/matrix-ios-sdk
1 participant
@Anderas