Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline displays multiple beginning headers #5717

Closed
Anderas opened this issue Mar 1, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1390
Closed

Timeline displays multiple beginning headers #5717

Anderas opened this issue Mar 1, 2022 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1390
Assignees
@Anderas
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort

Comments

@Anderas
Copy link
Contributor

Anderas commented Mar 1, 2022

Steps to reproduce

  1. Invite user A into DM or a new room
  2. Accept the invite by user A then leave the DM / room
  3. Invite user A again into a DM or a room with the same name
  4. Observe that user A now sees two "beginning of conversation" headers

The reason for this behaviour is that the timeline does not fully clear the cache and keeps twom.room.create events, even though it should only have one.

image

Outcome

What did you expect?

Only one "beginning of conversation" header is shown at top

What happened instead?

Seeing multiple headers

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Anderas Anderas added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Timeline labels Mar 1, 2022
@Anderas Anderas added S-Minor Impairs non-critical functionality or suitable workarounds exist Z-WTF WTF issues: High impact, Low Effort O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 1, 2022
@Anderas Anderas added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 3, 2022
This was referenced Mar 4, 2022
Merged
Closed
@Anderas Anderas self-assigned this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not reuse room files if the room is marked for deletion matrix-org/matrix-ios-sdk
1 participant
@Anderas