Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video rooms are filtered out of the room list #6149

Closed
robintown opened this issue May 12, 2022 · 1 comment
Closed

Video rooms are filtered out of the room list #6149

robintown opened this issue May 12, 2022 · 1 comment
Labels
A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. On develop.element.io, enable the video rooms feature in Labs, and create a video room
  2. Attempt to view that video room from Element iOS

Outcome

What did you expect?

The room should appear in the room list, and opening it should show the room's timeline, like with any other room. At this time, we don't require special support for video rooms on mobile beyond that.

What happened instead?

Because video rooms use a proprietary room type (io.element.video), they are filtered out of the room list, and attempting to view the room by tapping on a notification results in a blank page. See element-hq/element-meta#269 for further context

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@robintown robintown added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Room-List labels May 12, 2022
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue May 13, 2022
@stefanceriu
element-hq/element-ios/issues/6149 - Add io.element.video room type.
b021981
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue May 13, 2022
@stefanceriu
element-hq/element-ios/issues/6149 - Add io.element.video room type.
e9ce3ea
stefanceriu added a commit that referenced this issue May 13, 2022
@stefanceriu
/issues/6149 - Allow video rooms to be shown in the rooms list
bac1d47
@pixlwave pixlwave added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 13, 2022
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue May 16, 2022
@stefanceriu
element-hq/element-ios/issues/6149 - Add io.element.video room type.
f3883d1
stefanceriu added a commit that referenced this issue May 16, 2022
@stefanceriu
/issues/6149 - Allow video rooms to be shown in the rooms list
4a98b71
@robintown
Copy link
Member Author

This got done - thanks @stefanceriu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixlwave @robintown