Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The timeline displays closed polls in an incorrect order #7497

Closed
nimau opened this issue Apr 13, 2023 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1776 or #7518
Closed

The timeline displays closed polls in an incorrect order #7497

nimau opened this issue Apr 13, 2023 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1776 or #7518
Assignees
Labels
A-Polls T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@nimau
Copy link
Contributor

nimau commented Apr 13, 2023

Steps to reproduce

In a room with one or more closed polls, the final poll is correctly displayed, but the original one can be displayed at the wrong place in the timeline.

Step to reproduce:

  • create some polls in a room
  • add some text messages in the room
  • close the polls
  • clear the cache

When returning to the room, the end events are correctly displayed in the timeline, but the original polls are either displayed in the wrong order or in the wrong place in the timeline.

This appears to be due to the poll refresh mechanism where MXAggregatedPollsUpdater.refreshPoll(after:) fetches the original poll event and stores it into the store.

Original timeline (before the clear cache)
https://user-images.githubusercontent.com/4334885/231758612-9e26f445-c45b-440c-bc7a-b31b41b755cf.mov

Timeline displayed after the clear cache:
https://user-images.githubusercontent.com/4334885/231758913-3eead26f-1fea-476f-9e8c-d5520a4cdabf.mov

Another example:
Here, Polls were created in the following order: Poll L, Poll M, Poll N but there are displayed in the wrong order (c.f bubble timestamps)
https://user-images.githubusercontent.com/4334885/231760905-8e243eaa-749d-452e-9207-c34d71e08204.mov

Outcome

What did you expect?

After polls have been closed, the timeline should continue to display them in the original order.

What happened instead?

The polls are displayed in an incorrect order.

Your phone model

No response

Operating system version

iOS 16

Application version

Element version 1.10.11

Homeserver

No response

Will you send logs?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Polls T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
None yet
1 participant