Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invites badge behavior #1158

Closed
2 tasks done
Tracked by #991
alfogrillo opened this issue Mar 16, 2023 · 0 comments
Closed
2 tasks done
Tracked by #991

Invites badge behavior #1158

alfogrillo opened this issue Mar 16, 2023 · 0 comments

Comments

@alfogrillo
Copy link

alfogrillo commented Mar 16, 2023

As a user I want to see a badge in the all chats just when new invites arrives.

Designs

Matrix APIs
No new APIs are required for this task. There's an is_invite filter on sliding sync.

ACs

  • The invites's badge shows just when new invitations arrive
  • New invitations have a green badge in the invites list
  • Opening the invite list hides the badge
  • The badge shows again when the sliding sync delivers a new fresh invite
  • The badge doesn't sync on multiple sessions of the same device.

Tech details
The implementation may require a persisted piece of storage where the "last seen invites" are stored.

  • When opening the invites list we render the badges using the set S of the "last seen invites"
  • S will be updated just when the user sees a new set of invites in the invites list.
  • S should be a set of room IDs (aka strings)

Tasks

Preview Give feedback
  1. T-Enhancement Team: Element X Feature
    csmith
  2. T-Enhancement Team: Element X Feature
    alfogrillo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants