Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] 1:1 Chat detail page (DMs) #1167

Closed
2 tasks done
VolkerJunginger opened this issue Mar 22, 2023 · 9 comments
Closed
2 tasks done

[Story] 1:1 Chat detail page (DMs) #1167

VolkerJunginger opened this issue Mar 22, 2023 · 9 comments

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Mar 22, 2023

As a user I want to access the detail page for 1:1 chat so that I can get some info and modify settings.

A 1:1 chat has ALL of the following attributes

  • The dm flag is true
  • There are exact two room members
  • The chat is E2E encrypted

The following behaviour is expected from a 1:1 chat:

  • The room-name & avatar is the one of the conversation partner
  • No other user can be invited to the conversation
  • The conversation never ends
  • If a user deletes the 1:1 chat it is just deleting the history for himself. The other user can still write a message in that 1:1 chat.

Implement the following features:

Feature 1:1 Chat Details
Show Avatar userpic
Show Name username
Matrix-ID yes
Room Description / Topic "notes"
→ Encryption: Info
Block User yes

Scope

These should be a list of technical tasks which take ½-1 day to complete

Android

Preview Give feedback
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

iOS

Preview Give feedback
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

Stretch goals

None at this time

Out of scope

@amshakal
Copy link

Design will first work on features being implemented right now and then focus on the rest of the features as additional info might be needed for each and every one of them. eg. scope of audio/video call has not been defined yet, we don't know what encryption and verify user flow will look like based on what crypto team plans on doing etc.

Additionally slightly worried to have search here. Timeline might be a better place to search for messages.

@amshakal
Copy link

Are we sure we can and want to do links as well?

@manuroe
Copy link
Member

manuroe commented Apr 11, 2023

@kittykat: iOS is ready for QA

@kittykat kittykat assigned ghost Apr 14, 2023
@jmartinesp
Copy link
Member

@amshakal @kittykat @VolkerJunginger this is ready to be tested on Android, it should be included in the latest nightly.

@ghost
Copy link

ghost commented May 8, 2023

Testing this on iOS with Element X 1.1.0 (200), I am not sure how to start a DM from Element X itself. I am able to invite myself to a two person room (myself and a test account) using Element Web or one of the Element legacy apps. Not sure that's the same thing as a DM though. I assume it's not the same thing since the details view in Element X on my iPhone 12 mini look very different than the designs in Figma, but here are my results from testing that out anyway.

A 1:1 chat has ALL of the following attributes:
❓ The dm flag is true - not sure how to check this
✔️ There are exact two room members
✔️ The chat is E2E encrypted

The following behaviour is expected from a 1:1 chat:
✔️ The room-name is the one of the conversation partner
❌ The room-avatar is the one of the conversation partner - room avatar is the same as my avatar
❓ No other user can be invited to the conversation - I can invite a user to the room from outside Element X (eg. Web, legacy, etc)
❓ The conversation never ends - I am not sure what this means
❓ If a user deletes the 1:1 chat it is just deleting the history for himself. The other user can still write a message in that 1:1 chat. - I am not sure what is meant by delete in this context. I can leave the room or delete individual messages, but I'm not sure how to delete all chats as described.

@Velin92
Copy link
Member

Velin92 commented May 11, 2023

Testing this on iOS with Element X 1.1.0 (200), I am not sure how to start a DM from Element X itself. I am able to invite myself to a two person room (myself and a test account) using Element Web or one of the Element legacy apps. Not sure that's the same thing as a DM though. I assume it's not the same thing since the details view in Element X on my iPhone 12 mini look very different than the designs in Figma, but here are my results from testing that out anyway.

A 1:1 chat has ALL of the following attributes: ❓ The dm flag is true - not sure how to check this ✔️ There are exact two room members ✔️ The chat is E2E encrypted

The following behaviour is expected from a 1:1 chat: ✔️ The room-name is the one of the conversation partner ❌ The room-avatar is the one of the conversation partner - room avatar is the same as my avatar ❓ No other user can be invited to the conversation - I can invite a user to the room from outside Element X (eg. Web, legacy, etc) ❓ The conversation never ends - I am not sure what this means ❓ If a user deletes the 1:1 chat it is just deleting the history for himself. The other user can still write a message in that 1:1 chat. - I am not sure what is meant by delete in this context. I can leave the room or delete individual messages, but I'm not sure how to delete all chats as described.

@ashughes1

You can check the direct flag from element web in the settings of the room for now (there is no way yet to do that in El-X)

-Also a DM room, is essentially a room that is started by using the Start Chat (on El-Web since there is no invitation implemented yet fully in El-X) option and selecting a user instead of creating a room and inviting people.

  • Also the avatar of the user is the one that should be seen in the Details screen (for now we can't show it in the room list yet @VolkerJunginger but we should actually make a story for this)
  • Yes you can invite the users from outside El-X in a DM room, but that would change the DM room into a normal room. The important thing is that is not possible in El-X
  • I imagine the last two points mean that in El-X you can NOT leave the room however this is another point for discussion, since I am not sure if we should make DM non leavable.

@kittykat kittykat added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label May 26, 2023
@ghost
Copy link

ghost commented Jul 4, 2023

Retested this on Element X iOS 1.1.8 (270) and Element X Android 0.1.0-nightly (July 1, 2023). It seems to be working in line with the acceptance criteria above. Removing this from my backlog, but please tag me if you need something tested.

@VolkerJunginger
Copy link
Contributor Author

Even if we wanted to have a "topic" section for DMs we should remove this now for 1:1 chats in Android. We should not enable users to change the Room name and avatars in 1:1 conversations.

@kittykat kittykat unassigned ghost Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants