Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the typing notification below the composer #16304

Open
SimonBrandner opened this issue Jan 29, 2021 · 12 comments
Open

Move the typing notification below the composer #16304

SimonBrandner opened this issue Jan 29, 2021 · 12 comments
Labels
A-Composer A-Room-View A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team

Comments

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jan 29, 2021

Is your suggestion related to a problem? Please describe.
Currently, the typing notification leaves empty space when it dissapers. This might be solved by this but that is still not an ideal solution since that moves the timeline.

Describe the solution you'd like
The typing notification could be moved below the composer like Discord does it:

1*guDnRpPtR6cu_JTnajtSNg

This avoids any interaction with the timeline. I think this is a very important thing to consider when working on Scalable Composer.

@SimonBrandner
Copy link
Contributor Author

Screenshot_20210202_081144

I would suggest something like this. Here is my unprofessional design in Figma.

I will attempt to contact design and see what they think and if they like it I'd like to start working on this.

@SimonBrandner
Copy link
Contributor Author

This should probably be only done for the default layout. For the compact layout and IRC layout we should use what we have now

@SimonBrandner
Copy link
Contributor Author

To update on this, the design team has indicated that they are interested in this. We hope to discuss the change over the coming weeks.

@SimonBrandner
Copy link
Contributor Author

We can add a few things to the right of the typing notification, so we use space below the composer in some way. We could add:

  • Markdown on/off button
  • Mark as a spoiler button
  • Mark as NSFW button

@ShadowJonathan
Copy link
Contributor

We could add:

  • Markdown on/off button
  • Mark as a spoiler button
  • Mark as NSFW button

My humble suggestion would be to not add these "below" the composer, because that makes it feel like they're "out" of the composer in some fashion, I'd prefer these if these were kept "inside" the composer in some fashion, as that'd make it stay consistent with the user design language that these belong to the composer, not to (lets say) the room, or to a "general effect".

@nunoperalta
Copy link

Honest opinion here -- I'd love if the composer could go a bit upper in the screen, as many times I have Chrome's "status bar" (if the mouse is over some link, and Chrome shows the URL),
or Windows showing the title of one of the open applications in the task bar, and for some reason stuck (which happens often, but seems to be a glitch that can't be fixed),

and those things many times are OVER the composer, and I cannot see what I'm typing.

So if the composer can go a bit upper, I'd fully appreciate that!! :)

@SimonBrandner
Copy link
Contributor Author

@ddevjani, I am afraid this is a wrong issue

@ddevjani
Copy link

@ddevjani, I am afraid this is a wrong issue

apologies, thank you for pointing that out.

@niquewoodhouse
Copy link

To update on this, the design team has indicated that they are interested in this. We hope to discuss the change over the coming weeks.

Hey @SimonBrandner can I just check, do you know if this went anywhere yet? No problem if not, just want to double check, thanks

@SimonBrandner
Copy link
Contributor Author

Hey, if I remember correctly, it was a conversation with Nad in the Element Design room. I think we ended up postponing it. I can try to find the conversation when I get home. So, as far as I know, there haven't been any new developments

@niquewoodhouse
Copy link

I can try to find the conversation when I get home

Don't worry, that's enough context for me - thank you so much for the help and quick reply

@kgiebeler-xq-tec
Copy link

This should probably be only done for the default layout. For the compact layout and IRC layout we should use what we have now

I'd vote for making the proposed placement the default for all layouts (or have at least an option to do so).

I'm using the compact layout and the current typing indicator is so distracting (#19855) that I have to minimize Element whenever someone composes a longish reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Room-View A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

7 participants