Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets do not reliably receive room invitations #20622

Closed
dhenneke opened this issue Jan 18, 2022 · 1 comment
Closed

Widgets do not reliably receive room invitations #20622

dhenneke opened this issue Jan 18, 2022 · 1 comment
Labels
A-Widgets O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@dhenneke
Copy link
Contributor

Steps to reproduce

We want to create a widget that reacts to room invitations (and the set of stripped events that are provided for this room). However, when a room is already known to Element, the events are not reliably sent to the widget.

I created an example widget that shows the issue: https://github.com/dhenneke/element-bug-invite

Here is a video that demonstrates the behavior:

  1. The user is invited. The widget receives the event on the first invite. ✅
  2. The invite is cancelled. The widget receives the leave event. ✅
  3. The user is invited. The widget does not receive the event! ❌ (but Element shows the invitation)
  4. The invite is cancelled. The widget receives the leave event. ✅
bug.mp4

You can also test it with the deployed widget with /addwidget https://dhenneke-element-bug-invite.netlify.app/.

I think the event is skipped due to this logic, but I'm not sure what's special about these events that make them be skipped.

Outcome

What did you expect?

The widget receives the events

What happened instead?

The widget doesn't receive the events.

Operating system

macOS

Browser information

No response

URL for webapp

develop.element.io

Application version

Element version: 840867b-react-47cbef2af2c9-js-652b3a9208f0 Olm version: 3.2.8

Homeserver

No response

Will you send logs?

Yes

@dbkr dbkr added A-Widgets Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist and removed Help Wanted Extra attention is needed labels Jan 20, 2022
@dhenneke
Copy link
Contributor Author

I checked it again and can confirm that matrix-org/matrix-react-sdk#9802 resolved this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Widgets O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants