Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading the registration page should warn about data loss #21819

Closed
progval opened this issue Apr 16, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#8377
Closed
Labels
A-Login A-Registration good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@progval
Copy link
Contributor

progval commented Apr 16, 2022

Steps to reproduce

  1. Open https://app.element.io/ while not authenticated
  2. Click "Create an account"
  3. Fill the first form, click "Register" (the captcha page shows up)
  4. Refresh the page

There are many reasons to refresh the page at that point, like an issue with the captcha (eg. users who block Javascript by default may need to reload the page after whitlisting recaptcha)

Outcome

What did you expect?

Back to the registration form, with empty fields

What happened instead?

Should either be the original form with fields filled, or the captcha page

Operating system

Debian 11

Browser information

Firefox 91.8.0esr

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented Apr 16, 2022

I think the app should warn you on refresh that it'll lose your progress, storing the state like passwords isn't great, this app never stores passwords and it shouldn't start now.

@progval
Copy link
Contributor Author

progval commented Apr 16, 2022

Firefox normally takes care of repopulating fields on page reload.

But here it doesn't for some reason, probably because the form is dynamically created or something

@t3chguy
Copy link
Member

t3chguy commented Apr 16, 2022

probably because the form is dynamically created or something

Well yes, Element Web is an SPA written in React, no way around that.

@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Registration A-Login O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 16, 2022
@t3chguy t3chguy added the good first issue Good for newcomers label Apr 19, 2022
@t3chguy t3chguy changed the title Reloading the registration page loses field data Reloading the registration page should warn about data loss Apr 19, 2022
@yaya-usman
Copy link
Contributor

@t3chguy hi, I am interested in this issue but need some clarifications before linking my PR, do I need to customize the message as "you will lose your data" in the modal displaying the warning or rather leave it for the browser agent and as far as I know if I am not wrong, it's kinda not possible to customize the message.

@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2022

it's kinda not possible to customize the message.

I believe you are right, it should be sufficient though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login A-Registration good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants