Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You can't see earlier messages." appears in situations where room history is likely to be readable soon #838

Open
anoadragon453 opened this issue Nov 18, 2022 · 6 comments

Comments

@anoadragon453
Copy link
Member

Your use case

What would you like to do?

When being invited to an encrypted room by a client that has implemented support for matrix-org/matrix-spec-proposals#3061 (such as Element Web), one should expect to receive history for that room if room's history settings allow for it.

Today, it takes some time (a couple minutes in most cases) for the message keys to arrive. element-hq/element-web#23778 will make this situation better, but while the user is waiting they will see the following message:

image

Users see this and assume they will never receive the encrypted messages, and are surprised when the messages do eventually pop in (element-hq/element-web#23093) with no warning or notification.

I propose that Element shows a different message to the user if:

  1. the room history is configured such that room history should be shared, and
  2. the user was invited to the room (this can be dropped when MSCs such as MSC3917: Cryptographically Constrained Room Membership matrix-org/matrix-spec-proposals#3917 allow for other devices in the room to trust the newly added one(s)).

Element could say something along the lines of: "Waiting for earlier messages" with the subtitle "Older messages in this room are encrypted, and may take some time to appear."

Why would you like to do it?

The current UX does not prompt users to check the room again later to see if message history has been fetched.

Have you considered any alternatives?

No response

Additional context

Only some clients implement MSC3061 today. In cases that an inviting client does not, then message history will never be decrypted.

It's important to communicate to the user that while we are waiting for message history to be decrypted, it's possible that it never will be. Arguably message history for encrypted rooms should always be shared in the future as clients and the spec develops.

@anoadragon453 anoadragon453 changed the title "You can't see earlier messages \n Encrypted messages before this point are unavailable." appears in situations where room history is likely to be readable soon "You can't see earlier messages." appears in situations where room history is likely to be readable soon Nov 18, 2022
@t3chguy
Copy link
Member

t3chguy commented Nov 18, 2022

Duplicate of element-hq/element-web#22999

@t3chguy t3chguy marked this as a duplicate of element-hq/element-web#22999 Nov 18, 2022
@t3chguy t3chguy closed this as completed Nov 18, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2022
@anoadragon453
Copy link
Member Author

@t3chguy I took a look at that issue before making this one and I'm not convinced they're the same. element-hq/element-web#22999 seems to be talking about (or at least the discussion has evolved into) the case where a bug causes the room history to never appear.

This issue is specifically calling for wording to be updated.

@t3chguy
Copy link
Member

t3chguy commented Nov 18, 2022

The wording being updated would be misleading, there is no way to know if those messages will ever become decryptable. I suggest opening an element-meta issue if you wish for the messaging around unencryptable messages around invites to be changed across all platforms

@anoadragon453
Copy link
Member Author

there is no way to know if those messages will ever become decryptable.

Indeed, hence the last paragraph:

It's important to communicate to the user that while we are waiting for message history to be decrypted, it's possible that it never will be. Arguably message history for encrypted rooms should always be shared in the future as clients and the spec develops.

I'll move this to element-meta though; good shout.

@t3chguy t3chguy transferred this issue from element-hq/element-web Nov 18, 2022
@t3chguy
Copy link
Member

t3chguy commented Nov 18, 2022

@anoadragon453 have transferred

Context for product - this is an issue in all platforms, the messaging varies slightly but fundamentally means the same thing

@t3chguy t3chguy reopened this Nov 18, 2022
@anoadragon453
Copy link
Member Author

Oh, er, I already made a new copy at #839. Will close that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants