Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent Threads dot when last message in a thread is redacted #25670

Closed
Tracked by #24392
andybalaam opened this issue Jun 27, 2023 · 3 comments
Closed
Tracked by #24392

Persistent Threads dot when last message in a thread is redacted #25670

andybalaam opened this issue Jun 27, 2023 · 3 comments
Labels
A-Notifications A-Redaction A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@andybalaam
Copy link
Member

Steps to reproduce

  1. In a room with threads
  2. Where the latest message in the latest thread has been deleted (redacted). In fact, the last 2 events are redacted
  3. The thread read receipt points at the redacted message.

Outcome

What did you expect?

I have read all threads, and the receipt points at the latest message in the thread (which is redacted), so I would expect the dot in the top-right for Threads to disappear.

What happened instead?

The dot for unread Threads remains, and this room is a stuck unread room.

image

Operating system

Ubuntu 22.04

Browser information

Firefox 114.0.1

URL for webapp

https://develop.element.io

Application version

Element version: e4bf321-react-0d83a38a3eb5-js-9de4a057df6e Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes
@andybalaam andybalaam mentioned this issue Jun 27, 2023
Open
@andybalaam andybalaam changed the title Persistent Threads dot when Persistent Threads dot when last message in a thread is redacted Jun 27, 2023
@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Jun 28, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 1, 2023

image

Looks to be fixed

@t3chguy t3chguy closed this as completed Aug 1, 2023
@mightyiam
Copy link

Thank you!

@andybalaam
Copy link
Member Author

Yep, seems to be fixed for me, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-Redaction A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybalaam @mightyiam @t3chguy @robintown