Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the cancelled state properly #1160

Closed
Velin92 opened this issue Jun 26, 2023 · 2 comments · Fixed by #1161
Closed

Handle the cancelled state properly #1160

Velin92 opened this issue Jun 26, 2023 · 2 comments · Fixed by #1161
Assignees
@Velin92
Labels
T-Defect

Comments

@Velin92
Copy link
Member

Velin92 commented Jun 26, 2023

Steps to reproduce

Only the first unsent message is treated as unsent, because the cancelled state is not handled properly.

Outcome

We should handle it as an unsent state.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 assigned Velin92 and unassigned VolkerJunginger Jun 26, 2023
@Velin92
Copy link
Member Author

Velin92 commented Jun 26, 2023

related to: https://github.com/vector-im/element-x-ios-rageshakes/issues/500

@Velin92
Copy link
Member Author

Velin92 commented Jun 26, 2023

The cancelled state should be handled as a sendingFailed state.

@Velin92 Velin92 linked a pull request Jun 26, 2023 that will close this issue
Handling cancelled as a sendingFailed case #1161
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling cancelled as a sendingFailed case element-hq/element-x-ios
2 participants
@Velin92 @VolkerJunginger