-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send current user location #1272
Conversation
Generated by 🚫 Danger Swift against 0f9f7a9 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1272 +/- ##
===========================================
- Coverage 40.16% 40.02% -0.14%
===========================================
Files 434 428 -6
Lines 27676 27295 -381
Branches 14204 14080 -124
===========================================
- Hits 11115 10924 -191
+ Misses 16264 16078 -186
+ Partials 297 293 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/StaticLocationScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/View/StaticLocationScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/LocationSharingScreenModels.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/StaticLocationScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/StaticLocationScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/View/StaticLocationScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/LocationSharing/View/StaticLocationScreen.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a few suggestions
312043e
to
391c906
Compare
Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
…oordinator.swift Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
…iewModel.swift Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
a7c1146
to
306f6c0
Compare
306f6c0
to
8b51e56
Compare
ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
fixes #1180
add the share current user location feature and also viewing the current location in the expanded detail map from timeline.
There is a difference in this 2 modes because for the view we ask permission only after the user press the navigator icon; instead for the share screen we ask permission as soon as possible.