Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send current user location #1272

Merged
merged 21 commits into from
Jul 11, 2023
Merged

Send current user location #1272

merged 21 commits into from
Jul 11, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Jul 6, 2023

fixes #1180

add the share current user location feature and also viewing the current location in the expanded detail map from timeline.
There is a difference in this 2 modes because for the view we ask permission only after the user press the navigator icon; instead for the share screen we ask permission as soon as possible.

sharelocation

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0f9f7a9

@flescio flescio changed the title Flescio/share current location Send current user location Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 24.51% and project coverage change: -0.14 ⚠️

Comparison is base (5ae2271) 40.16% compared to head (312043e) 40.02%.

❗ Current head 312043e differs from pull request most recent head 8b51e56. Consider uploading reports for the commit 8b51e56 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1272      +/-   ##
===========================================
- Coverage    40.16%   40.02%   -0.14%     
===========================================
  Files          434      428       -6     
  Lines        27676    27295     -381     
  Branches     14204    14080     -124     
===========================================
- Hits         11115    10924     -191     
+ Misses       16264    16078     -186     
+ Partials       297      293       -4     
Flag Coverage Δ
unittests 22.76% <24.51%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 42.77% <0.00%> (ø)
...mentX/Sources/Other/MapLibre/MapLibreMapView.swift 0.00% <0.00%> (ø)
...ationSharing/StaticLocationScreenCoordinator.swift 0.00% <0.00%> (ø)
...ns/LocationSharing/View/StaticLocationScreen.swift 0.00% <0.00%> (ø)
.../LocationSharing/LocationSharingScreenModels.swift 38.04% <73.68%> (+20.47%) ⬆️
...ocationSharing/StaticLocationScreenViewModel.swift 75.00% <90.90%> (+6.57%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flescio flescio marked this pull request as ready for review July 6, 2023 15:18
@flescio flescio requested a review from a team as a code owner July 6, 2023 15:18
@flescio flescio requested review from Velin92 and removed request for a team July 6, 2023 15:18
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few suggestions

@alfogrillo alfogrillo force-pushed the flescio/share_current_location branch from 312043e to 391c906 Compare July 11, 2023 09:14
alfogrillo and others added 5 commits July 11, 2023 11:41
…oordinator.swift

Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
…iewModel.swift

Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
@alfogrillo alfogrillo force-pushed the flescio/share_current_location branch from a7c1146 to 306f6c0 Compare July 11, 2023 09:42
@alfogrillo alfogrillo force-pushed the flescio/share_current_location branch from 306f6c0 to 8b51e56 Compare July 11, 2023 09:43
@alfogrillo alfogrillo enabled auto-merge (squash) July 11, 2023 10:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit 153149d into develop Jul 11, 2023
@alfogrillo alfogrillo deleted the flescio/share_current_location branch July 11, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send current user location
4 participants