Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't permalink UISIs #1338

Closed
ara4n opened this issue Jul 16, 2023 · 3 comments
Closed

Can't permalink UISIs #1338

ara4n opened this issue Jul 16, 2023 · 3 comments
Assignees
Labels
A-E2EE Encryption A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Needs-Product

Comments

@ara4n
Copy link
Member

ara4n commented Jul 16, 2023

Steps to reproduce

  1. Receive a UISI
  2. Try to copy a permalink to it so I can reference it in a rageshake
  3. Discover there's no "copy link to this msg" option on the UISI :(

Outcome

What did you expect?

Ability to permalink undecryptable msgs.

Your phone model

No response

Operating system version

No response

Application version

291

Homeserver

No response

Will you send logs?

No

@pixlwave
Copy link
Member

@VolkerJunginger Are you happy to make this change? It is the opposite of what you said here.

@stefanceriu stefanceriu added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 19, 2023
@VolkerJunginger
Copy link

I am not a fan of exposing the regular message interaction to errors. I think the right way to do this is to introduce a "Report bug" action for UTDs that creates a bug with the link to that message.

@ara4n
Copy link
Member Author

ara4n commented Aug 15, 2023

The main way of debugging UISIs is for a developer to copy-paste the URLs of the affected messages and collate with the logs. If there is no way to copy the URL short of "reporting a bug", that will be incredibly frustrating.

Given these errors exist primarily for developers to debug these bugs, I think we should prioritise what developers would need to fix UISIs (the last thing we need is to make them even harder to debug!) - and that means being able to copy their links.

Otherwise it's like saying "huh, this webpage is 500ing. therefore i'm not going to let you see its URL."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Encryption A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Needs-Product
Projects
None yet
Development

No branches or pull requests

5 participants