Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeline scrolling issues #276

Closed
stefanceriu opened this issue Oct 31, 2022 · 0 comments
Closed

Fix timeline scrolling issues #276

stefanceriu opened this issue Oct 31, 2022 · 0 comments
Assignees
@stefanceriu
Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@stefanceriu
Copy link
Member

stefanceriu commented Oct 31, 2022 •
edited by VolkerJunginger
Loading

The current timline list is based on a very fragile collection view introspection method. After moving to iOS16 we should try to replace it with a LazyVStack (for performance reasons too) and try building it in a more SwiftUI fashion
@stefanceriu stefanceriu self-assigned this Oct 31, 2022
stefanceriu added a commit that referenced this issue Nov 1, 2022
@stefanceriu
Fixes #276 - Rebuilt room timeline:
0e0dbe8 
- Removed the need for the ListCollectionViewAdapter
- Rewrote the TimelineItemList without using introspection
- Added ReversedScrollView for laying out items at the bottom/trailing
- Rewrote TimelineProvider diffing through CollectionDifference (similar to the RoomSummaryProvider)
- Added back `scrollDismissesKeyboard`  behavior
- Various other tweaks and fixes
@stefanceriu stefanceriu mentioned this issue Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanceriu