Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sliding sync proxy URL on the server selection screen #320

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

stefanceriu
Copy link
Member

This PR will:

  • move the sliding sync server url to the user defaults
  • expose it on the server selection screen
  • make the app more resilient to slidinc sync configuration errors. Instead of throwing fatal errors it will allow the app to start and show the home screen but will always stay in the skeletons view. The user can choose to log out and change the server settings.

Screenshot 2022-11-17 at 09 27 03

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against e07ee1e

@stefanceriu stefanceriu force-pushed the stefan/exposeSSProxyConfiguration branch from 54cd8dd to 8c0e9f5 Compare November 17, 2022 07:39
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 33.77% // Head: 33.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (119933e) compared to base (2fd0491).
Patch coverage: 60.00% of modified lines in pull request are covered.

❗ Current head 119933e differs from pull request most recent head e07ee1e. Consider uploading reports for the commit e07ee1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #320   +/-   ##
========================================
  Coverage    33.77%   33.77%           
========================================
  Files          252      253    +1     
  Lines        16514    16594   +80     
  Branches      8917     9000   +83     
========================================
+ Hits          5577     5605   +28     
- Misses       10774    10831   +57     
+ Partials       163      158    -5     
Flag Coverage Δ
unittests 13.62% <26.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/BuildSettings.swift 0.00% <0.00%> (ø)
...cation/ServerSelection/ServerSelectionModels.swift 100.00% <ø> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 0.00% <0.00%> (ø)
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 58.12% <71.87%> (+2.72%) ⬆️
ElementX/Sources/Other/ElementSettings.swift 93.33% <100.00%> (-6.67%) ⬇️
...ion/ServerSelection/ServerSelectionViewModel.swift 86.84% <100.00%> (-5.76%) ⬇️
...n/ServerSelection/View/ServerSelectionScreen.swift 66.66% <100.00%> (-11.91%) ⬇️
...entX/Sources/Services/Client/MockClientProxy.swift 20.58% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu force-pushed the stefan/exposeSSProxyConfiguration branch from 8c0e9f5 to 119933e Compare November 17, 2022 10:04
…p more resilient to slidinc sync configuration errors, remove fatal errors
@stefanceriu stefanceriu force-pushed the stefan/exposeSSProxyConfiguration branch from 119933e to e07ee1e Compare November 17, 2022 11:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu enabled auto-merge (rebase) November 17, 2022 11:54
@stefanceriu stefanceriu merged commit 276daf0 into develop Nov 17, 2022
@stefanceriu stefanceriu deleted the stefan/exposeSSProxyConfiguration branch November 17, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants