Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button should block until /logout is executed. #340

Closed
ara4n opened this issue Nov 24, 2022 · 0 comments
Closed

Logout button should block until /logout is executed. #340

ara4n opened this issue Nov 24, 2022 · 0 comments
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Nov 24, 2022

If you press the logout button, you immediately get thrown out of the app... even if the /logout request hasn't actually executed yet (e.g. due to bad connectivity). Therefore if you then kill & relaunch the app, you find yourself still logged in, which is terrifying.

We should block on a spinner or something when you hit logout, so the user knows when it's actually happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants