Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the background task that pauses the SDK when resigning active. #438

Closed
pixlwave opened this issue Jan 11, 2023 · 0 comments · Fixed by #903
Closed

Cleanup the background task that pauses the SDK when resigning active. #438

pixlwave opened this issue Jan 11, 2023 · 0 comments · Fixed by #903
Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@pixlwave
Copy link
Member

pixlwave commented Jan 11, 2023

In the AppCoordinator we currently wrap the call to pause in a background task. However we never call stop() on this task which leaves it running, resulting in the system terminating the app. Steps to fix:

  • Investigate whether Rust actually needs more than a few seconds to pause (the task is there to extend this time).
  • If it does, then either the ClientProxy.stopSync() method should be made into an async/blocking call, or we need to add a callback so we can stop the background task when it is finished.
@pixlwave pixlwave added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Jan 11, 2023
@pixlwave pixlwave changed the title Cleanup the background task that pauses the SDK when backgrounding the app. Cleanup the background task that pauses the SDK when resigning active. Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant