Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling a reply/edit can sometimes leave some items dimmed out. #542

Closed
pixlwave opened this issue Feb 6, 2023 · 2 comments · Fixed by #606
Closed

Cancelling a reply/edit can sometimes leave some items dimmed out. #542

pixlwave opened this issue Feb 6, 2023 · 2 comments · Fixed by #606
Assignees
@Velin92
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-User Story Team: Element X Platform X-Needs-Design Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@pixlwave
Copy link
Member

pixlwave commented Feb 6, 2023 •
edited by VolkerJunginger
Loading

I think this usually happens if the items are offscreen at the time of cancelling the reply/edit.

Note: The current Figma doesn't show a highlight during editing or replying so it may well be enough to simply remove this behaviour.

Nightly 1.0.19
@pixlwave pixlwave added Z-BBQ-Beta Required for ElementX - BBQ - Beta A-Timeline T-Defect labels Feb 6, 2023
@kittykat kittykat added T-User Story S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely Team: Element X Platform labels Feb 20, 2023
@Velin92 Velin92 self-assigned this Feb 20, 2023
@Velin92
Copy link
Member

Velin92 commented Feb 20, 2023 •
edited
Loading

Tested on my physical device and currently the dimming works fine for Reply (even after a cancel), but actually does not work at all for Edit (is actually not implemented at all in the code).
However since the dimming feature is not present in Figma, I wanted to know if we can remove it or if I should add it to the Edit behaviour too.

Here is a visual example of the dimming for a reply:
IMG_0137

@callumu

Velin92 added a commit that referenced this issue Feb 20, 2023
@Velin92
#542 removed reply/edit dimming
c97262d
@Velin92 Velin92 linked a pull request Feb 20, 2023 that will close this issue
Removed Edit/Reply Dimming #606
Merged
@callumu
Copy link

callumu commented Feb 20, 2023

For now, let's remove dimming on both edit and reply. I agree that there needs to be more clarity to help the user understand what message they're editing and replying to, but we can revisit this in the future

Velin92 added a commit that referenced this issue Feb 21, 2023
@Velin92
Removed Edit/Reply Dimming (#606)
e2f2604 
* #542 removed reply/edit dimming

* removed unneeded didSet
@stefanceriu stefanceriu mentioned this issue Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-User Story Team: Element X Platform X-Needs-Design Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Edit/Reply Dimming element-hq/element-x-ios
4 participants
@kittykat @pixlwave @Velin92 @callumu