-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SDK version and fix breaking changes. #709
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Generated by 🚫 Danger Swift against acc4edd |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #709 +/- ##
===========================================
+ Coverage 52.48% 52.74% +0.25%
===========================================
Files 273 275 +2
Lines 15041 14937 -104
Branches 9408 9279 -129
===========================================
- Hits 7895 7879 -16
+ Misses 6917 6827 -90
- Partials 229 231 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -23,7 +23,7 @@ private class SlidingSyncViewObserver: SlidingSyncListRoomListObserver, SlidingS | |||
let roomListDiffPublisher = PassthroughSubject<SlidingSyncListRoomsListDiff, Never>() | |||
|
|||
/// Publishes the current state of sliding sync, such as whether its catching up or live. | |||
let stateUpdatePublisher = CurrentValueSubject<SlidingSyncState, Never>(.cold) | |||
let stateUpdatePublisher = CurrentValueSubject<SlidingSyncState, Never>(.fullyLoaded) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whooops, this one is wrong 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb didn't catch it
Updates to v1.0.47 and handles renaming of sliding sync states.