Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK version and fix breaking changes. #709

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Bump SDK version and fix breaking changes. #709

merged 1 commit into from
Mar 20, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 20, 2023

Updates to v1.0.47 and handles renaming of sliding sync states.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift#L139 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against acc4edd

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 37.19% and project coverage change: +0.25 🎉

Comparison is base (bbd6409) 52.48% compared to head (acc4edd) 52.74%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #709      +/-   ##
===========================================
+ Coverage    52.48%   52.74%   +0.25%     
===========================================
  Files          273      275       +2     
  Lines        15041    14937     -104     
  Branches      9408     9279     -129     
===========================================
- Hits          7895     7879      -16     
+ Misses        6917     6827      -90     
- Partials       229      231       +2     
Flag Coverage Δ
unittests 21.63% <37.19%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tX/Sources/Other/SwiftUI/Views/LoadableImage.swift 81.13% <0.00%> (-1.89%) ⬇️
...s/Screens/FilePreview/FilePreviewCoordinator.swift 0.00% <0.00%> (ø)
...s/Screens/FilePreview/View/FilePreviewScreen.swift 0.00% <0.00%> (ø)
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 62.66% <0.00%> (-0.43%) ⬇️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 12.50% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 85.71% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 52.22% <0.00%> (+0.38%) ⬆️
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 43.52% <0.00%> (-0.44%) ⬇️
...Sources/Services/Client/SlidingSyncViewProxy.swift 60.65% <0.00%> (-1.64%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 merged commit 66651c0 into develop Mar 20, 2023
@Velin92 Velin92 deleted the sdk/update branch March 20, 2023 18:26
@@ -23,7 +23,7 @@ private class SlidingSyncViewObserver: SlidingSyncListRoomListObserver, SlidingS
let roomListDiffPublisher = PassthroughSubject<SlidingSyncListRoomsListDiff, Never>()

/// Publishes the current state of sliding sync, such as whether its catching up or live.
let stateUpdatePublisher = CurrentValueSubject<SlidingSyncState, Never>(.cold)
let stateUpdatePublisher = CurrentValueSubject<SlidingSyncState, Never>(.fullyLoaded)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooops, this one is wrong 🤦‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb didn't catch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants