-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL and LTR mixed languages fix for optimal timestamp support #1055
Conversation
Generated by 🚫 Danger Swift against 3cae485 |
0e5114c
to
b992098
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1055 +/- ##
===========================================
- Coverage 45.16% 44.90% -0.26%
===========================================
Files 370 371 +1
Lines 23868 23983 +115
Branches 12691 12758 +67
===========================================
- Hits 10779 10769 -10
- Misses 12792 12919 +127
+ Partials 297 295 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
49d6f23
to
1a27ca2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left minor comments
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Outdated
Show resolved
Hide resolved
06b162b
to
c10b238
Compare
c10b238
to
014391f
Compare
…yText.swift Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
…an improvements, and is not really needed
014391f
to
3cae485
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
RTL layout:
LTR layout: