Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL and LTR mixed languages fix for optimal timestamp support #1055

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 8, 2023

RTL layout:
Screenshot 2023-06-08 at 14 52 22
LTR layout:
Screenshot 2023-06-08 at 14 36 54

@Velin92 Velin92 requested a review from a team as a code owner June 8, 2023 13:02
@Velin92 Velin92 requested review from alfogrillo and removed request for a team June 8, 2023 13:02
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3cae485

changelog.d/1052.feature Outdated Show resolved Hide resolved
@Velin92 Velin92 force-pushed the mauroromito/fix_rtl_in_ltr branch from 0e5114c to b992098 Compare June 8, 2023 13:06
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: -0.26 ⚠️

Comparison is base (9b347c0) 45.16% compared to head (1a27ca2) 44.90%.

❗ Current head 1a27ca2 differs from pull request most recent head 3cae485. Consider uploading reports for the commit 3cae485 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
- Coverage    45.16%   44.90%   -0.26%     
===========================================
  Files          370      371       +1     
  Lines        23868    23983     +115     
  Branches     12691    12758      +67     
===========================================
- Hits         10779    10769      -10     
- Misses       12792    12919     +127     
+ Partials       297      295       -2     
Flag Coverage Δ
unittests 23.75% <18.18%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Screens/RoomScreen/View/Style/TimelineStyler.swift 7.14% <0.00%> (-3.50%) ⬇️
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 25.16% <0.00%> (-1.74%) ⬇️
ElementX/Sources/Other/Extensions/String.swift 74.54% <88.88%> (+0.54%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 force-pushed the mauroromito/fix_rtl_in_ltr branch from 49d6f23 to 1a27ca2 Compare June 8, 2023 22:10
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left minor comments

@Velin92 Velin92 force-pushed the mauroromito/fix_rtl_in_ltr branch from 06b162b to c10b238 Compare June 9, 2023 10:26
@Velin92
Copy link
Member Author

Velin92 commented Jun 9, 2023

i had to do a a bit of change, I removed the prefix thing because it could mess up with messages that contained only blockquotes, the timestamp still works fine for RTL strings, but however it could be displayed slightly closer (so the spacing is less consistent for RTL strings), probably there is a fix for that too, but it's going to be a bit too time consuming, and worth revisiting later.
Screenshot 2023-06-09 at 12 29 31

@Velin92 Velin92 enabled auto-merge (squash) June 9, 2023 10:27
@Velin92 Velin92 force-pushed the mauroromito/fix_rtl_in_ltr branch from c10b238 to 014391f Compare June 9, 2023 11:34
@Velin92 Velin92 force-pushed the mauroromito/fix_rtl_in_ltr branch from 014391f to 3cae485 Compare June 9, 2023 11:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 42e083d into develop Jun 9, 2023
@Velin92 Velin92 deleted the mauroromito/fix_rtl_in_ltr branch June 9, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants