Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a failed echo, just cancels and resends it #1207

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 28, 2023

RPReplay_Final1687967955.2.MP4

@Velin92 Velin92 requested a review from a team as a code owner June 28, 2023 16:37
@Velin92 Velin92 requested review from pixlwave and amshakal and removed request for a team June 28, 2023 16:37
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 027c4da

@Velin92 Velin92 force-pushed the mauroromito/editing_a_failed_echo branch from 90211c1 to b80e411 Compare June 28, 2023 16:40
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (3b114c2) 41.06% compared to head (d082a22) 41.10%.

❗ Current head d082a22 differs from pull request most recent head 027c4da. Consider uploading reports for the commit 027c4da to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1207      +/-   ##
===========================================
+ Coverage    41.06%   41.10%   +0.03%     
===========================================
  Files          414      413       -1     
  Lines        26489    26471      -18     
  Branches     13688    13688              
===========================================
+ Hits         10879    10880       +1     
+ Misses       15317    15298      -19     
  Partials       293      293              
Flag Coverage Δ
unittests 23.24% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/Screens/RoomScreen/View/TimelineItemMenu.swift 0.00% <0.00%> (ø)
...ne/TimelineController/RoomTimelineController.swift 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if product are happy with the reordering 👍

@Velin92 Velin92 enabled auto-merge (squash) June 29, 2023 09:07
@Velin92 Velin92 force-pushed the mauroromito/editing_a_failed_echo branch 2 times, most recently from d082a22 to a5ccd1d Compare June 29, 2023 13:16
@Velin92 Velin92 force-pushed the mauroromito/editing_a_failed_echo branch from a5ccd1d to 027c4da Compare June 29, 2023 14:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit b2ab610 into develop Jun 29, 2023
@Velin92 Velin92 deleted the mauroromito/editing_a_failed_echo branch June 29, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants