Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound Room Details #1369

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Compound Room Details #1369

merged 4 commits into from
Jul 21, 2023

Conversation

pixlwave
Copy link
Member

This PR adopts Compound in the Room Details screen.

Additionally it tweaks some previews of our project button styles and uses the placeholder screen instead of the splash screen when clearing your cache.

@pixlwave pixlwave requested a review from a team as a code owner July 20, 2023 10:33
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 20, 2023 10:33
@pixlwave pixlwave force-pushed the doug/compound-room-details branch from 8235aad to 8d34a13 Compare July 20, 2023 10:37
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0d04e75

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (3b0961f) 45.38% compared to head (0d04e75) 45.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1369      +/-   ##
===========================================
- Coverage    45.38%   45.26%   -0.12%     
===========================================
  Files          386      386              
  Lines        24711    24736      +25     
  Branches     12603    12609       +6     
===========================================
- Hits         11214    11197      -17     
- Misses       13209    13253      +44     
+ Partials       288      286       -2     
Flag Coverage Δ
unittests 22.86% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 0.00% <0.00%> (ø)
...s/Other/SwiftUI/Form Styles/FormButtonStyles.swift 40.23% <0.00%> (-1.49%) ⬇️
...Sources/Other/SwiftUI/Views/AvatarHeaderView.swift 55.81% <0.00%> (-2.73%) ⬇️
...ens/RoomDetailsScreen/View/RoomDetailsScreen.swift 47.61% <0.00%> (-8.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@pixlwave pixlwave force-pushed the doug/compound-room-details branch from 8d34a13 to 03dd566 Compare July 21, 2023 11:19
@pixlwave pixlwave enabled auto-merge July 21, 2023 11:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave added this pull request to the merge queue Jul 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 21, 2023
@pixlwave pixlwave merged commit fbe05a8 into develop Jul 21, 2023
@pixlwave pixlwave deleted the doug/compound-room-details branch July 21, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants