-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compound Room Details #1369
Compound Room Details #1369
Conversation
8235aad
to
8d34a13
Compare
Generated by 🚫 Danger Swift against 0d04e75 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
===========================================
- Coverage 45.38% 45.26% -0.12%
===========================================
Files 386 386
Lines 24711 24736 +25
Branches 12603 12609 +6
===========================================
- Hits 11214 11197 -17
- Misses 13209 13253 +44
+ Partials 288 286 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment
8d34a13
to
03dd566
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR adopts Compound in the Room Details screen.
Additionally it tweaks some previews of our project button styles and uses the placeholder screen instead of the splash screen when clearing your cache.