Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for offset 1 not making new messages auto scroll #1371

Merged
merged 11 commits into from
Jul 20, 2023
Merged

Fix for offset 1 not making new messages auto scroll #1371

merged 11 commits into from
Jul 20, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 20, 2023

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner July 20, 2023 11:53
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 20, 2023 11:53
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7f7c7df

pixlwave
pixlwave approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 enabled auto-merge (squash) July 20, 2023 12:05
@Velin92 Velin92 linked an issue Jul 20, 2023 that may be closed by this pull request
Timeline often scrolljumps down when the composer goes multiline #1244
Closed
@Velin92 Velin92 force-pushed the mauroromito/fix_scrolling_bug branch from 6151493 to 7f7c7df Compare July 20, 2023 13:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 5a24d08 into develop Jul 20, 2023
@Velin92 Velin92 deleted the mauroromito/fix_scrolling_bug branch July 20, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeline often scrolljumps down when the composer goes multiline
2 participants
@Velin92 @pixlwave