Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display avatars full screen when tapping on them from the room or mem… #1448

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

stefanceriu
Copy link
Member

…ber detail screens

@stefanceriu stefanceriu requested a review from a team as a code owner August 4, 2023 12:44
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 4, 2023 12:44
@stefanceriu stefanceriu force-pushed the stefan/fullScreenRoomAvatars branch from 6b3f2c3 to 55b83d5 Compare August 4, 2023 12:45
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 55b83d5

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 9.19% and project coverage change: -0.15% ⚠️

Comparison is base (68f8bfe) 53.91% compared to head (55b83d5) 53.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1448      +/-   ##
===========================================
- Coverage    53.91%   53.77%   -0.15%     
===========================================
  Files          393      393              
  Lines        25888    25963      +75     
  Branches     13107    13131      +24     
===========================================
+ Hits         13958    13961       +3     
- Misses       11551    11623      +72     
  Partials       379      379              
Flag Coverage Δ
unittests 23.10% <9.19%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 41.36% <0.00%> (-0.22%) ⬇️
...Sources/Other/SwiftUI/Views/AvatarHeaderView.swift 40.42% <0.00%> (-15.39%) ⬇️
...ns/RoomDetailsScreen/RoomDetailsScreenModels.swift 60.17% <ø> (ø)
...ens/RoomDetailsScreen/View/RoomDetailsScreen.swift 50.93% <0.00%> (-0.81%) ⬇️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 83.33% <0.00%> (-16.67%) ⬇️
...rDetailsScreen/RoomMemberDetailsScreenModels.swift 3.84% <ø> (ø)
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 49.47% <0.00%> (-7.16%) ⬇️
...rListScreen/RoomMembersListScreenCoordinator.swift 38.23% <0.00%> (-3.71%) ⬇️
...RoomDetailsScreen/RoomDetailsScreenViewModel.swift 79.11% <9.09%> (-7.59%) ⬇️
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 72.60% <23.07%> (-27.40%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@stefanceriu stefanceriu merged commit 3515494 into develop Aug 4, 2023
@stefanceriu stefanceriu deleted the stefan/fullScreenRoomAvatars branch August 4, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants