Re-enable and (hopefuly) simplify background app refresh handling #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
requested review from
Velin92 and
pixlwave
and removed request for
a team and
Velin92
|
Kudos, SonarCloud Quality Gate passed!
|
Generated by 🚫 Danger Swift against e9dae62 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1462 +/- ##
===========================================
- Coverage 52.49% 52.38% -0.12%
===========================================
Files 400 400
Lines 26662 26646 -16
Branches 13357 13354 -3
===========================================
- Hits 13997 13958 -39
- Misses 12284 12308 +24
+ Partials 381 380 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously disabled by rust not being able to recover correctly after stopping a sync and processing the stop signal on app foregrounding.
That has been since fixed and the original implementation should work but I also wanted to simplify it a bit.