Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reply to media crash caused by missing room context (and implicit… #1472

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix reply to media crash caused by missing room context (and implicit… #1472

merged 1 commit into from
Aug 10, 2023

Conversation

stefanceriu
Copy link
Member

…ly image provider) on the new composer toolbar

@stefanceriu stefanceriu requested a review from pixlwave August 10, 2023 08:27
@stefanceriu stefanceriu requested a review from a team as a code owner August 10, 2023 08:27
@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7c509a1

@stefanceriu
Fix reply to media crash caused by missing room context (and implicit…
7c509a1 
…ly image provider) on the new composer toolbar
@stefanceriu stefanceriu force-pushed the stefan/replyToMediaCrashFix branch from 578065b to 7c509a1 Compare August 10, 2023 09:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pixlwave
pixlwave approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit 8a69ca1 into develop Aug 10, 2023
@stefanceriu stefanceriu deleted the stefan/replyToMediaCrashFix branch August 10, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave