Adopt fuzzy searching through the RoomListService's dynamic filter #1483

stefanceriu · 2023-08-11T14:26:56Z

No description provided.

github-actions · 2023-08-11T14:28:15Z

	Warnings
⚠️	Please provide a description for this PR.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.
⚠️	ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L116 - A doc comment should be attached to a declaration. (`orphaned_doc_comment`)

Generated by 🚫 Danger Swift against 62cb683

codecov · 2023-08-11T14:53:30Z

Codecov Report

Patch coverage: 5.26% and project coverage change: +0.07% 🎉

Comparison is base (25f66d2) 52.92% compared to head (62cb683) 52.99%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1483      +/-   ##
===========================================
+ Coverage    52.92%   52.99%   +0.07%     
===========================================
  Files          400      400              
  Lines        26875    26878       +3     
  Branches     13442    13440       -2     
===========================================
+ Hits         14223    14245      +22     
+ Misses       12250    12229      -21     
- Partials       402      404       +2

Flag	Coverage Δ
unittests	`23.05% <5.26%> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../Sources/Screens/HomeScreen/HomeScreenModels.swift	`86.00% <0.00%> (+2.66%)`	⬆️
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	`52.91% <0.00%> (-0.26%)`	⬇️
...ervices/Room/RoomSummary/RoomSummaryProvider.swift	`63.02% <0.00%> (-3.76%)`	⬇️
...Room/RoomSummary/RoomSummaryProviderProtocol.swift	`44.23% <ø> (ø)`
...urces/Screens/HomeScreen/HomeScreenViewModel.swift	`83.02% <50.00%> (-0.25%)`	⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pixlwave

Oh this is going to be nice! 🔎

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift

pixlwave · 2023-08-11T18:18:43Z

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift

+            return
+        }
+
+        _ = listUpdatesSubscriptionResult?.dynamicFilter.set(kind: .fuzzyMatchRoomName(pattern: pattern.lowercased()))


Not part of this specifically, but it would be nice if the lowercases() happened on the Rust side instead of client side.

@Hywan This is a workaround as I noticed the rust side doesn't take care of it. Do you think we can move it?

The fuzzy match uses smart case: if everything is in lower-case, the case is ignored, otherwise if at least one character is in uppercase, the case isn't ignored. So I would suggest to not put the search pattern in lowercase here.